-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add fleet server host UI #142894
[Fleet] Add fleet server host UI #142894
Conversation
446e7ec
to
8138d4d
Compare
8138d4d
to
60ee8aa
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
@elasticmachine merge upstream |
Let me check this with @nchaulet in the afternoon. I'm not sure why it was done this way. |
Yes I saw that, but tbh I'm not sure it makes much sense to have it optional, the other objects in that page all have required names and it seems weird to me to assign multiple hosts without indicating them. Happy to change it if this is an issue :) |
I think we can multiple Fleet server config entry with the same hosts, and it could make sense later when we add proxy here. |
@juliaElastic I miss that during the implementation, if it's okay with you I think it can come as a followup , where we address the landing page too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Summary
Closes #137785
Depends on #142746
That PR allow to edit fleet server host in the UI.
I also changed the full policy generation to use the new fleet server host instead of the settings saved object.
UI Changes
Todo