Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Observability plugin from timelines unused dependencies on TGrid usage #143607

Merged

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Oct 19, 2022

Due to the migrating Observability to use the new Alerts table

getAlertsStateTable: (props: AlertsTableStateProps) => ReactElement<AlertsTableStateProps>;

instead of TGrid, we are able now to clean timelines plugin from TGrid 'standalone' and 'embedded' components which was introduced during RAC initiative.

Current PR is a cleaning up of the code in Observability plugin which has references to TGrid component usage usage.
Follow up issue for cleaning Security Solution.

@YulNaumenko YulNaumenko self-assigned this Oct 19, 2022
@YulNaumenko YulNaumenko added technical debt Improvement of the software architecture and operational architecture Team:Threat Hunting:Investigations Security Solution Investigations Team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 19, 2022
@YulNaumenko YulNaumenko changed the title Clean Observability plugin from timelines unused dependancies on TGrid usage Cleaned up Observability plugin from timelines unused dependencies on TGrid usage Oct 19, 2022
@YulNaumenko YulNaumenko marked this pull request as ready for review October 19, 2022 02:54
@YulNaumenko YulNaumenko requested review from a team as code owners October 19, 2022 02:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@YulNaumenko
Copy link
Contributor Author

@elasticmachine merge upstream

@kqualters-elastic
Copy link
Contributor

@YulNaumenko I think you should just delete the failing tests, this whole directory https://github.com/elastic/kibana/tree/main/x-pack/test/plugin_functional/plugins/timelines_test and this https://github.com/elastic/kibana/tree/main/x-pack/test/plugin_functional/test_suites/timelines and all references to these files. Never did anything more than verify that the standalone version didn't explode on render.

Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 once ci is happy from the now irrelevant smoke tests

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable Observability changes LGTM.

@YulNaumenko YulNaumenko enabled auto-merge (squash) October 19, 2022 16:38
@YulNaumenko YulNaumenko merged commit 64b5efe into elastic:main Oct 19, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 478 475 -3
timelines 258 255 -3
total -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 522.0KB 520.7KB -1.4KB
securitySolution 10.0MB 10.0MB -30.0B
timelines 26.3KB 74.0KB +47.7KB
total +46.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 67.6KB 67.5KB -139.0B
timelines 222.2KB 172.8KB -49.5KB
total -49.6KB
Unknown metric groups

async chunk count

id before after diff
timelines 7 10 +3

ESLint disabled line counts

id before after diff
timelines 34 32 -2

References to deprecated APIs

id before after diff
timelines 20 10 -10

Total ESLint disabled count

id before after diff
timelines 34 32 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:Threat Hunting:Investigations Security Solution Investigations Team technical debt Improvement of the software architecture and operational architecture v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants