-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up Observability plugin from timelines unused dependencies on TGrid usage #143607
Cleaned up Observability plugin from timelines unused dependencies on TGrid usage #143607
Conversation
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
@elasticmachine merge upstream |
@YulNaumenko I think you should just delete the failing tests, this whole directory https://github.com/elastic/kibana/tree/main/x-pack/test/plugin_functional/plugins/timelines_test and this https://github.com/elastic/kibana/tree/main/x-pack/test/plugin_functional/test_suites/timelines and all references to these files. Never did anything more than verify that the standalone version didn't explode on render. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 once ci is happy from the now irrelevant smoke tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable Observability changes LGTM.
…ps' into observability-remove-timeline-deps
…ps' into observability-remove-timeline-deps
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
Due to the migrating Observability to use the new Alerts table
kibana/x-pack/plugins/triggers_actions_ui/public/plugin.ts
Line 110 in f92c76c
instead of TGrid, we are able now to clean timelines plugin from TGrid 'standalone' and 'embedded' components which was introduced during RAC initiative.
Current PR is a cleaning up of the code in Observability plugin which has references to TGrid component usage usage.
Follow up issue for cleaning Security Solution.