Cleaned up Observability plugin from timelines unused dependencies on TGrid usage

tsconfig.base.json

@@ -475,8 +475,6 @@
       "@kbn/global-search-test-plugin/*": ["x-pack/test/plugin_functional/plugins/global_search_test/*"],
       "@kbn/resolver-test-plugin": ["x-pack/test/plugin_functional/plugins/resolver_test"],
       "@kbn/resolver-test-plugin/*": ["x-pack/test/plugin_functional/plugins/resolver_test/*"],
-      "@kbn/timelines-test-plugin": ["x-pack/test/plugin_functional/plugins/timelines_test"],
-      "@kbn/timelines-test-plugin/*": ["x-pack/test/plugin_functional/plugins/timelines_test/*"],
       "@kbn/security-test-endpoints-plugin": ["x-pack/test/security_functional/fixtures/common/test_endpoints"],
       "@kbn/security-test-endpoints-plugin/*": ["x-pack/test/security_functional/fixtures/common/test_endpoints/*"],
       "@kbn/application-usage-test-plugin": ["x-pack/test/usage_collection/plugins/application_usage_test"],

x-pack/plugins/observability/kibana.json

@@ -27,7 +27,6 @@
     "features",
     "inspector",
     "ruleRegistry",
-    "timelines",
     "triggersActionsUi",
     "inspector",
     "unifiedSearch",

x-pack/plugins/observability/public/application/types.ts

@@ -24,8 +24,6 @@ import { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public';
 import { LensPublicStart } from '@kbn/lens-plugin/public';
 import { TriggersAndActionsUIPublicPluginStart } from '@kbn/triggers-actions-ui-plugin/public';
 import { CasesUiStart } from '@kbn/cases-plugin/public';
-import { TimelinesUIStart } from '@kbn/timelines-plugin/public';
-
 export interface ObservabilityAppServices {
   application: ApplicationStart;
   cases: CasesUiStart;
@@ -42,7 +40,6 @@ export interface ObservabilityAppServices {
   stateTransfer: EmbeddableStateTransfer;
   storage: IStorageWrapper;
   theme: ThemeServiceStart;
-  timelines: TimelinesUIStart;
   triggersActionsUi: TriggersAndActionsUIPublicPluginStart;
   uiSettings: IUiSettingsClient;
   isDev?: boolean;

x-pack/plugins/observability/public/config/register_alerts_table_configuration.tsx

@@ -12,9 +12,9 @@ import { casesFeatureId, observabilityFeatureId } from '../../common';
 import { useBulkAddToCaseActions } from '../hooks/use_alert_bulk_case_actions';
 import { TopAlert, useToGetInternalFlyout } from '../pages/alerts';
 import { getRenderCellValue } from '../pages/alerts/components/render_cell_value';
-import { addDisplayNames } from '../pages/alerts/containers/alerts_table_t_grid/add_display_names';
-import { columns as alertO11yColumns } from '../pages/alerts/containers/alerts_table_t_grid/alerts_table_t_grid';
-import { getRowActions } from '../pages/alerts/containers/alerts_table_t_grid/get_row_actions';
+import { addDisplayNames } from '../pages/alerts/containers/alerts_table/add_display_names';
+import { columns as alertO11yColumns } from '../pages/alerts/containers/alerts_table/default_columns';
+import { getRowActions } from '../pages/alerts/containers/alerts_table/get_row_actions';
 import type { ObservabilityRuleTypeRegistry } from '../rules/create_observability_rule_type_registry';
 import type { ConfigSchema } from '../plugin';
 

x-pack/plugins/observability/public/hooks/use_alert_bulk_case_actions.ts

@@ -12,7 +12,7 @@ import {
   ADD_TO_CASE_DISABLED,
   ADD_TO_EXISTING_CASE,
   ADD_TO_NEW_CASE,
-} from '../pages/alerts/containers/alerts_table_t_grid/translations';
+} from '../pages/alerts/containers/alerts_table/translations';
 import { useGetUserCasesPermissions } from './use_get_user_cases_permissions';
 import { ObservabilityAppServices } from '../application/types';
 

x-pack/plugins/observability/public/pages/alerts/components/index.ts

@@ -10,7 +10,6 @@ export * from './render_cell_value';
 export * from './severity_badge';
 export * from './workflow_status_filter';
 export * from './alerts_search_bar';
-export * from './default_cell_actions';
 export * from './filter_for_value';
 export * from './parse_alert';
 export * from './alerts_status_filter';

x-pack/plugins/observability/public/pages/alerts/components/observability_actions.tsx

@@ -24,10 +24,7 @@ import { useKibana } from '../../../utils/kibana_react';
 import { useGetUserCasesPermissions } from '../../../hooks/use_get_user_cases_permissions';
 import { parseAlert } from './parse_alert';
 import { translations, paths } from '../../../config';
-import {
-  ADD_TO_EXISTING_CASE,
-  ADD_TO_NEW_CASE,
-} from '../containers/alerts_table_t_grid/translations';
+import { ADD_TO_EXISTING_CASE, ADD_TO_NEW_CASE } from '../containers/alerts_table/translations';
 import { ObservabilityAppServices } from '../../../application/types';
 import { RULE_DETAILS_PAGE_ID } from '../../rule_details/types';
 import type { TopAlert } from '../containers/alerts_page/types';

x-pack/plugins/observability/public/pages/alerts/components/render_cell_value/index.ts

@@ -5,4 +5,4 @@
  * 2.0.
  */
 
-export { getRenderCellValue, getMappedNonEcsValue } from './render_cell_value';
+export { getRenderCellValue } from './render_cell_value';

x-pack/plugins/observability/public/pages/alerts/containers/alerts_table_t_grid/add_display_names.ts → x-pack/plugins/observability/public/pages/alerts/containers/alerts_table/add_display_names.ts

@@ -6,12 +6,10 @@
  */
 import { ALERT_DURATION, ALERT_REASON, ALERT_STATUS, TIMESTAMP } from '@kbn/rule-data-utils';
 import { EuiDataGridColumn } from '@elastic/eui';
-import type { ColumnHeaderOptions } from '@kbn/timelines-plugin/common';
 import { translations } from '../../../../config';
 
 export const addDisplayNames = (
-  column: Pick<EuiDataGridColumn, 'display' | 'displayAsText' | 'id' | 'initialWidth'> &
-    ColumnHeaderOptions
+  column: Pick<EuiDataGridColumn, 'display' | 'displayAsText' | 'id' | 'initialWidth'>
 ) => {
   if (column.id === ALERT_REASON) {
     return { ...column, displayAsText: translations.alertsTable.reasonColumnDescription };

x-pack/plugins/observability/public/pages/alerts/containers/alerts_table/default_columns.tsx

@@ -0,0 +1,52 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+/**
+ * We need to produce types and code transpilation at different folders during the build of the package.
+ * We have types and code at different imports because we don't want to import the whole package in the resulting webpack bundle for the plugin.
+ * This way plugins can do targeted imports to reduce the final code bundle
+ */
+import { ALERT_DURATION, ALERT_REASON, ALERT_STATUS, TIMESTAMP } from '@kbn/rule-data-utils';
+
+import { EuiDataGridColumn } from '@elastic/eui';
+
+import type { ColumnHeaderOptions } from '@kbn/timelines-plugin/common';
+
+import { translations } from '../../../../config';
+
+/**
+ * columns implements a subset of `EuiDataGrid`'s `EuiDataGridColumn` interface,
+ * plus additional TGrid column properties
+ */
+export const columns: Array<
+  Pick<EuiDataGridColumn, 'display' | 'displayAsText' | 'id' | 'initialWidth'> & ColumnHeaderOptions
+> = [
+  {
+    columnHeaderType: 'not-filtered',
+    displayAsText: translations.alertsTable.statusColumnDescription,
+    id: ALERT_STATUS,
+    initialWidth: 110,
+  },
+  {
+    columnHeaderType: 'not-filtered',
+    displayAsText: translations.alertsTable.lastUpdatedColumnDescription,
+    id: TIMESTAMP,
+    initialWidth: 230,
+  },
+  {
+    columnHeaderType: 'not-filtered',
+    displayAsText: translations.alertsTable.durationColumnDescription,
+    id: ALERT_DURATION,
+    initialWidth: 116,
+  },
+  {
+    columnHeaderType: 'not-filtered',
+    displayAsText: translations.alertsTable.reasonColumnDescription,
+    id: ALERT_REASON,
+    linkField: '*',
+  },
+];