Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Adds button group to navigate to "All services" #142911

Merged
merged 14 commits into from
Oct 30, 2022
Merged

[APM] Adds button group to navigate to "All services" #142911

merged 14 commits into from
Oct 30, 2022

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Oct 6, 2022 •
edited
Loading

Closes #142084.

apm-service-groups-button-group-nav4

@ogupte ogupte added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 6, 2022
@ogupte ogupte requested a review from a team as a code owner October 6, 2022 19:51
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

sorenlouv
sorenlouv approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ogupte added 5 commits October 28, 2022 11:59
@ogupte
Merge branch 'main' into apm-142084-service-groups-button-group-nav
97e693a
@ogupte
addressed feedback:
ef3e2fa 
- Use 'All services' as the default landing page
    - swap order of button group ->  All services, Service groups
    - move tour from the create button to service group half of the button group
- have service groups always enabled but marked Beta
    - removed some branching logic in routes / page templates
    - add 'Send feedback' link
- fixed service count in cards
@ogupte
Merge branch 'main' into apm-142084-service-groups-button-group-nav
b475f32
@ogupte
fixes tests and deep links
6277761
@ogupte
change button group to single type
b2f7543
@ogupte ogupte enabled auto-merge (squash) October 29, 2022 05:02
@ogupte ogupte merged commit 18e37cf into elastic:main Oct 30, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 548 538 -10

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
observability 39 37 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +321.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 29.0KB 28.9KB -156.0B
observability 68.2KB 68.0KB -180.0B
total -336.0B
Unknown metric groups

API count

id before after diff
observability 551 541 -10

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 30, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
@jloleysens
Merge branch 'main' into files-move-to-src
866c302 
* main: (41 commits)
  [api-docs] Daily api_docs build (elastic#144212)
  Add readonly view to role management (elastic#143893)
  [api-docs] Daily api_docs build (elastic#144208)
  [APM] Adds button group to navigate to "All services" (elastic#142911)
  Update react-query to ^4.12.0 (main) (elastic#139986)
  [APM] Support specific fields when creating service groups (elastic#142201) (elastic#143881)
  [api-docs] Daily api_docs build (elastic#144203)
  [ts] add stub index.d.ts in @kbn/ui-shared-deps-npm
  [Synthetics] Fix failing Synthetics Integration test (elastic#144175)
  chore(NA): remove @types/pkg link creation when generating a new package (elastic#144200)
  [Osquery] Update schema to v5.5.1 (elastic#144090)
  [ci] remove github-checks-reporter (elastic#144193)
  [8.6][ML Inference] Verify pipeline usage before deletion (elastic#144053)
  [ts] ts refs cache was removed, remove capture task
  Added Rollups CCS Test (elastic#144074)
  [auto] migrate existing plugin/package configs
  [ts] stop building @types packages in bootstrap
  skip failing test suite (elastic#142762)
  skip failing test suite (elastic#144186)
  [Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy (elastic#144105)
  ...
gbamparop
gbamparop reviewed Oct 31, 2022
View reviewed changes
x-pack/plugins/apm/public/components/app/service_groups/service_group_save/create_button.tsx
'Group services together to build curated inventory views that remove noise and simplify investigations across services. Groups are Kibana space-specific and available for any users with appropriate access.',
}
)}
// <ServiceGroupsTour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogupte could this be removed instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, i'll remove it while working on alerts integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbamparop gbamparop gbamparop left review comments

@bmorelli25 bmorelli25 bmorelli25 left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Implement new design for "All services" and "Service groups" toggle
7 participants
@ogupte @elasticmachine @kibana-ci @sorenlouv @bmorelli25 @gbamparop @kibanamachine