Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use specific dimensions for service group creation #142201

Closed
Tracked by #143881
dannycroft opened this issue Sep 29, 2022 · 5 comments · Fixed by #143881
Closed
Tracked by #143881

[APM] Use specific dimensions for service group creation #142201

dannycroft opened this issue Sep 29, 2022 · 5 comments · Fixed by #143881
Labels
apm:release-feature APM UI - Release Feature Goal apm:service-groups apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.6.0

Comments

@dannycroft
Copy link

dannycroft commented Sep 29, 2022 •
edited
Loading

To help maintain a consistent experience in terms of performance, we'd like to use a specific list of dimensions when creating a service group. This piece of work is to update the service group creation flow so that only the following dimensions are available to query against:

  • Agent.name
  • Service.name
  • Service.language.name
  • Service.environment
  • Labels.*

Links
@dannycroft dannycroft added Team:APM All issues that need APM UI Team support apm:service-groups apm:release-feature APM UI - Release Feature Goal v8.6.0 labels Sep 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv
Copy link
Member

We might consider restricting the dimensions even further. If we want to make things easier for ourselves, it should be possible to retrieve alerts using the service group kql query. We can only do that if every dimension that we decide on here are also persisted for every alerts

That being said, this list does look reasonably short so it's not an issue to add all of those to the APM alerts.

@sorenlouv
Copy link
Member

@chrisdistasio Did we mean to include service.language.name? We don't use it in the UI, and it's not an ECS field.

@chrisdistasio
Copy link

is it possible to add service.runtime.name? Accolade is using this to create groups for lambda?

Alternately, they could be guided to use labels.

@chrisdistasio
Copy link

chrisdistasio commented Oct 5, 2022 •
edited by dannycroft
Loading

@sqren

@chrisdistasio Did we mean to include service.language.name? We don't use it in the UI, and it's not an ECS field.

Yes, this was a field identified as one in use based on telemetry.

@kpatticha kpatticha mentioned this issue Oct 5, 2022
Closed
@ogupte ogupte self-assigned this Oct 5, 2022
@ogupte ogupte mentioned this issue Oct 24, 2022
Merged
3 tasks
ogupte added a commit to ogupte/kibana that referenced this issue Oct 26, 2022
@ogupte
[APM] Support specific fields when creating service groups (elastic#1…
be46156 
…42201)
ogupte added a commit that referenced this issue Oct 29, 2022
@ogupte @kibanamachine
[APM] Support specific fields when creating service groups (#142201) (#…
796751e 
…143881)

* [APM] Support specific fields when creating service groups (#142201)

* add support to anomaly rule type to store supported service group fields in alert

* address PR feedback and fixes checks

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* add API tests for field validation

* fixes linting

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* fixes multi_terms sort order paths, for each rule type query

* adds unit tests and moves some source files

* fixed back import path

* PR feedback

* improvements to kuery validation

* fixes selecting 'All' in service.name, transaction.type fields when creating/editing APM Rules (#143861)

Co-authored-by: kibanamachine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this issue Oct 31, 2022
@jloleysens
Merge branch 'main' into files-move-to-src
866c302 
* main: (41 commits)
  [api-docs] Daily api_docs build (elastic#144212)
  Add readonly view to role management (elastic#143893)
  [api-docs] Daily api_docs build (elastic#144208)
  [APM] Adds button group to navigate to "All services" (elastic#142911)
  Update react-query to ^4.12.0 (main) (elastic#139986)
  [APM] Support specific fields when creating service groups (elastic#142201) (elastic#143881)
  [api-docs] Daily api_docs build (elastic#144203)
  [ts] add stub index.d.ts in @kbn/ui-shared-deps-npm
  [Synthetics] Fix failing Synthetics Integration test (elastic#144175)
  chore(NA): remove @types/pkg link creation when generating a new package (elastic#144200)
  [Osquery] Update schema to v5.5.1 (elastic#144090)
  [ci] remove github-checks-reporter (elastic#144193)
  [8.6][ML Inference] Verify pipeline usage before deletion (elastic#144053)
  [ts] ts refs cache was removed, remove capture task
  Added Rollups CCS Test (elastic#144074)
  [auto] migrate existing plugin/package configs
  [ts] stop building @types packages in bootstrap
  skip failing test suite (elastic#142762)
  skip failing test suite (elastic#144186)
  [Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy (elastic#144105)
  ...
@MiriamAparicio MiriamAparicio added the apm:test-plan-done Pull request that was successfully tested during the test plan label Nov 22, 2022
@gbamparop gbamparop mentioned this issue Dec 19, 2022
Closed
@mielastic mielastic mentioned this issue Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:release-feature APM UI - Release Feature Goal apm:service-groups apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Support specific fields when creating service groups (#142201) ogupte/kibana
6 participants
@dannycroft @sorenlouv @ogupte @elasticmachine @MiriamAparicio @chrisdistasio