[APM] Transaction type selector in rule flyout incorrectly lists "All" option

[dgieselaar]

In various transaction-related rule types, we offer the user the choice to select a transaction type. The value should be required, as metrics from different transaction types usually don't mix. A good example of this is page-load transactions from the RUM agent vs route-change transactions. The former involve a lot more heavy lifting to bootstrap initial resources for a page. The latter is usually a lot quicker as it happens past the bootstrapping stage.

However, the transaction type selector that we use lists the "All" option, even though we don't enumerate over transaction type in some of the rule types. Additionally, once the user selects "All", the label is displayed as "ENVIRONMENT_ALL", which does not make sense in this context. Presumably this is because we use a shared component (SuggestionSelect) in an unintended manner. Once the user has created a rule, it will yield no results, as the value used for filtering on transaction type is the string "ENVIRONMENT_ALL".

We should make sure that:

• the all option works similar to service.environment: ALL is interpreted as: don't apply a filter for transaction.type, but enumerate over all transaction types in the rule executor
• the selected service name is taken into account when displaying suggestions for transaction type

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[sorenlouv]

the all option is removed for transaction type in all rule types

I don't think we need to remove the All option. Instead, it should work like the "All" option for environments and services, meaning, it should be added to the multi_terms agg, but not added as a filter.

[dgieselaar]

@sqren that's fair, I've updated the description.

[sorenlouv]

However, the transaction type selector that we use lists the "All" option, even though we don't enumerate over transaction type in some of the rule types.

I think this will be fixed in #143881

[sorenlouv]

It's not just the transaction type selector that has a bug with the "All" option - it's all of the dropdowns.

alerting.bugs.mp4

Should we use this issue for fixing all of them, or create separate issues for each dropdown (service name and service environment are the other two)?

[sorenlouv]

Another problem that affects all the selectors, is when the field is cleared. This should probably be equivalent of selecting "All" but now it's set to undefined, which causes an error for the preview.

environment.picker.mp4

[ogupte]

However, the transaction type selector that we use lists the "All" option, even though we don't enumerate over transaction type in some of the rule types.

I think this will be fixed in #143881

I believe the only Rule type that we didn't enumerate over transaction type was latency threshold (transaction duration) which is now part of a multi_terms agg in my PR #143881. There, i've also fixed the issue when selecting 'All' would set ENVIRONMENT_ALL as the value, now an empty string is the value. I've also updated the termQuery utility function to optionally test for empty string.

[sorenlouv]

@ogupte did you also fixed the bugs i mentioned in this issue or should I create new issues for those?

[ogupte]

did you also fixed the bugs i mentioned in this issue or should I create new issues for those?

The PR fixed the issue when clearing field so that it would behave like selecting 'All' and when selecting 'All' it would show 'ENVIRONMENT_ALL'.
But it does not fix any issue of a broken preview.