Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Implement new design for "All services" and "Service groups" toggle #142084

Closed
dannycroft opened this issue Sep 28, 2022 · 5 comments · Fixed by #142911
Closed

[APM] Implement new design for "All services" and "Service groups" toggle #142084

dannycroft opened this issue Sep 28, 2022 · 5 comments · Fixed by #142911
Assignees
@ogupte
Labels
apm:release-feature APM UI - Release Feature Goal apm:service-groups apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.6.0

Comments

@dannycroft
Copy link

dannycroft commented Sep 28, 2022 •
edited
Loading

After collecting feedback on the service groups feature, we'd like to streamline the UI a little and remove the "All services" service group entry that appears once an initial group has been created and present it as an EuiButtonGroup below the "Services" header instead. Allowing the user to quickly toggle between experiences.

Before

all-services-groups

After

all-services-groups-after

Notes

  • This issue is only to remove the "All services" group from the service group list and implement the "pill" based toggle below the view heading. Other items in the provided screens are out of scope.

Links
@dannycroft dannycroft added Team:APM All issues that need APM UI Team support apm:service-groups apm:release-feature APM UI - Release Feature Goal v8.6.0 labels Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@dannycroft dannycroft changed the title Implement new design for "All services" and "Service groups" toggle [APM] Implement new design for "All services" and "Service groups" toggle Sep 28, 2022
@cauemarcondes
Copy link
Contributor

@chrisdistasio / @boriskirov currently we show the tour component on the All services card. Since this card is going to be removed, where should we place the tour now?

@ogupte ogupte self-assigned this Oct 3, 2022
@ogupte
Copy link
Contributor

ogupte commented Oct 6, 2022

@cauemarcondes I can move the tour to anchor on the new "All services" half of the button group.

ogupte added a commit to ogupte/kibana that referenced this issue Oct 6, 2022
@ogupte
[APM] Adds button group to navigate to "All services" (elastic#142084)
b2d6070
@ogupte ogupte mentioned this issue Oct 6, 2022
Merged
@boriskirov
Copy link
Contributor

boriskirov commented Oct 12, 2022 •
edited
Loading

We had a productive discussion with @ogupte about how we can make an impactful change in the navigation experience:

  1. The aim would be to keep the routing as it is, but give the ability for the user to switch between two views on their Services page. Either All services or Service groups.
  2. We can have a return button link on every service group if a service group is entered.
  3. We can also present an empty state of Service groups when the feature is GA for example.

image

@ogupte
Copy link
Contributor

ogupte commented Oct 12, 2022

Thank you, i'll make change with these updates, will move this issue back to "In Progress"

ogupte added a commit that referenced this issue Oct 30, 2022
@ogupte @kibanamachine
[APM] Adds button group to navigate to "All services" (#142911)
18e37cf 
* [APM] Adds button group to navigate to "All services" (#142084)

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adds button group legend, fixes spacing and translation IDs

* makes the button group part of the page template

* addresses feedback

* addressed feedback:
- Use 'All services' as the default landing page
    - swap order of button group ->  All services, Service groups
    - move tour from the create button to service group half of the button group
- have service groups always enabled but marked Beta
    - removed some branching logic in routes / page templates
    - add 'Send feedback' link
- fixed service count in cards

* fixes tests and deep links

* change button group to single type

Co-authored-by: kibanamachine <[email protected]>
@MiriamAparicio MiriamAparicio added the apm:test-plan-done Pull request that was successfully tested during the test plan label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:release-feature APM UI - Release Feature Goal apm:service-groups apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Adds button group to navigate to "All services" ogupte/kibana
6 participants
@dannycroft @ogupte @boriskirov @elasticmachine @MiriamAparicio @cauemarcondes