Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] - Make exceptions read only when displaying deleted rule details #142258

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Sep 29, 2022

Summary

Addresses 141899.

When displaying a rule that has since been deleted, the exception tabs will render as read only.

Screen Shot 2022-09-29 at 10 58 05 AM

Also took opportunity to address follow up copy edit from #141682 (comment)

Screen Shot 2022-09-29 at 10 59 29 AM

Checklist

@yctercero yctercero added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team v8.5.0 v8.6.0 labels Sep 29, 2022
@yctercero yctercero self-assigned this Sep 29, 2022
@yctercero yctercero requested review from a team as code owners September 29, 2022 18:03
@yctercero yctercero requested a review from jpdjere September 29, 2022 18:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Detection rules, bulk edit Prerequisites "before each" hook for "Prebuilt and custom rules selected: user proceeds with custom rules editing"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +120.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Rules LGTM 👍

Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for covering this edge case!

@yctercero yctercero merged commit f415b3b into elastic:main Sep 30, 2022
@yctercero yctercero deleted the 141899 branch September 30, 2022 16:17
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2022
…laying deleted rule details (elastic#142258)

### Summary

Addresses 141899.

(cherry picked from commit f415b3b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2022
…laying deleted rule details (#142258) (#142387)

### Summary

Addresses 141899.

(cherry picked from commit f415b3b)

Co-authored-by: Yara Tercero <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 2, 2022
…laying deleted rule details (elastic#142258)

### Summary

Addresses 141899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants