-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Exceptions] - Make exceptions read only when displaying deleted rule details #142258
Conversation
…hat has since been deleted
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detection Rules LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for covering this edge case!
…laying deleted rule details (elastic#142258) ### Summary Addresses 141899. (cherry picked from commit f415b3b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…laying deleted rule details (#142258) (#142387) ### Summary Addresses 141899. (cherry picked from commit f415b3b) Co-authored-by: Yara Tercero <[email protected]>
…laying deleted rule details (elastic#142258) ### Summary Addresses 141899.
Summary
Addresses 141899.
When displaying a rule that has since been deleted, the exception tabs will render as read only.
Also took opportunity to address follow up copy edit from #141682 (comment)
Checklist