[Security Solution][Exceptions] - Fixes up some bugs in the all exception items view #141682

yctercero · 2022-09-23T17:16:01Z

Summary

Addresses #140709, #141056, #141421, #141042

Removed the option of selecting a single row - not sure there's much use there.

Updated text under exception tabs to indicate to user where each exception type is evaluated

Updated the exception lists management page search placeholder

Fixed some jank occurring on changing rows per page in the exception tabs

rowChange.mov

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2022-09-23T17:16:04Z

Pinging @elastic/security-solution (Team: SecuritySolution)

yctercero · 2022-09-23T18:06:06Z

@elasticmachine merge upstream

dhurley14

Looks great thanks for the fixes!

xcrzx · 2022-09-26T11:19:29Z

It looks like there's a bug somewhere in the exception pagination. I just opened a random rule and saw "Showing 1-0 of 0":

...ution/public/detection_engine/rule_exceptions/components/all_exception_items_table/index.tsx

...urity_solution/public/detections/pages/detection_engine/rules/all/exceptions/translations.ts

...ution/public/detection_engine/rule_exceptions/components/all_exception_items_table/index.tsx

nastasha-solomon · 2022-09-26T19:05:16Z

@yctercero thanks for tagging the docs team for the UI copy review! Please find my comments and questions below.

Recommend capitalizing "id" in the placeholder text.

Couple notes/questions about this image:

If the sentence at the top always displays (i.e., it shows regardless of whether endpoint/rule exceptions exist) you can probably remove "Endpoint exceptions are applied to the endpoint and the rule detection" from the center text.
Can we change the sentence at the top to align it with the language we use in our docs? For example, "Endpoint exceptions are added to both the detection rule and the Elastic Endpoint agent on your hosts." I feel like this explanation is pretty clear (shoutout to @joepeeples for the lang)
Where is the second sentence linking to? In its current state, I'm not quite sure what it's recommending.

A few suggestions for the text in this image:

Swap "e.g." with "for example". We try to avoid using abbreviations like i.e. and e.g. to accomodate ESL folks.
Is the query in the placeholder text KQL? If it is, what are your thoughts on the following revision:
Filter exceptions using Kibana Query Language (KQL), for example, name:"my list"

…ff_bugs

yctercero · 2022-09-29T02:28:58Z

@yctercero thanks for tagging the docs team for the UI copy review! Please find my comments and questions below.

Recommend capitalizing "id" in the placeholder text.

I updated it to specify that it was meant to be list_id, not the list ID. Does that make sense?

Couple notes/questions about this image:

If the sentence at the top always displays (i.e., it shows regardless of whether endpoint/rule exceptions exist) you can probably remove "Endpoint exceptions are applied to the endpoint and the rule detection" from the center text.

Done!

Can we change the sentence at the top to align it with the language we use in our docs? For example, "Endpoint exceptions are added to both the detection rule and the Elastic Endpoint agent on your hosts." I feel like this explanation is pretty clear (shoutout to @joepeeples for the lang)

Where is the second sentence linking to? In its current state, I'm not quite sure what it's recommending.

Yea, I like that. I updated the text and removed that link - it was confusing. I was trying to give guidance as to how to link the endpoint list to the rule, but it's super not clear.

A few suggestions for the text in this image:

Swap "e.g." with "for example". We try to avoid using abbreviations like i.e. and e.g. to accomodate ESL folks.

Is the query in the placeholder text KQL? If it is, what are your thoughts on the following revision:
Filter exceptions using Kibana Query Language (KQL), for example, name:"my list"

Updated the text! It's not KQL, it's simple query syntax - I updated it to try to reflect that - let me know what you think.

…into exceptions_postff_bugs

…n list linked to rule

yctercero · 2022-09-29T03:44:03Z

It looks like there's a bug somewhere in the exception pagination. I just opened a random rule and saw "Showing 1-0 of 0":

Thanks for finding this! It's a result of an empty exception list being linked to a rule. Pushed up a fix.

…-ref HEAD~1..HEAD --fix'

kibana-ci · 2022-09-29T05:01:23Z

💚 Build Succeeded

Buildkite Build
Commit: e4da812

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.6MB	6.6MB	+1.6KB

History

💔 Build #75395 failed 1b9a011
💔 Build #75374 failed 8848cf6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

xcrzx

Thank you for the fixes, LGTM 👍

yctercero · 2022-09-29T15:19:16Z

@nastasha-solomon I'm going to merge, but please still comment if changes are needed to copy and I will follow up with them.

nastasha-solomon

Just left one comment. Thanks!

nastasha-solomon · 2022-09-29T15:20:54Z

...urity_solution/public/detections/pages/detection_engine/rules/all/exceptions/translations.ts

  {
-    defaultMessage: 'e.g. Example List Name',
+    defaultMessage: 'Search by name or list_id',


Sorry for the delayed response. Feel free to revert this to list id or list ID so that it matches the way you're representing the name field in this helper text. That's all - everything else looks good. :) Thank you!

All good! I'll update and post follow up PR

Fixed here - #142258

…tion items view (elastic#141682) ### Summary Addresses elastic#140709, elastic#141056, elastic#141421, elastic#141042 (cherry picked from commit 49d0858)

kibanamachine · 2022-09-29T15:25:25Z

💚 All backports created successfully

Status	Branch	Result
✅	8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…tion items view (#141682) (#142237) ### Summary Addresses #140709, #141056, #141421, #141042 (cherry picked from commit 49d0858) Co-authored-by: Yara Tercero <[email protected]>

…tion items view (elastic#141682) ### Summary Addresses elastic#140709, elastic#141056, elastic#141421, elastic#141042

fixing up some bugs in the all exception items view

8848cf6

yctercero self-assigned this Sep 23, 2022

yctercero requested review from a team as code owners September 23, 2022 17:16

yctercero requested a review from xcrzx September 23, 2022 17:16

yctercero changed the title ~~fixing up some bugs in the all exception items view~~ [Security Solution][Exceptions] - Fixes up some bugs in the all exception items view Sep 23, 2022

yctercero requested a review from a team September 23, 2022 17:17

yctercero mentioned this pull request Sep 23, 2022

[DOCS][Security Solution][Exceptions] - New exceptions UI/UX elastic/security-docs#2304

Closed

yctercero removed the ci:cloud-redeploy Always create a new Cloud deployment label Sep 23, 2022

Merge branch 'main' into exceptions_postff_bugs

1b9a011

dhurley14 approved these changes Sep 23, 2022

View reviewed changes

xcrzx reviewed Sep 26, 2022

View reviewed changes

nastasha-solomon added the ui-copy Review of UI copy with docs team is recommended label Sep 26, 2022

Merge branch 'main' of github.com:elastic/kibana into exceptions_post…

61617ee

…ff_bugs

yctercero added 3 commits September 28, 2022 19:30

apply feedback

2366561

Merge branch 'exceptions_postff_bugs' of github.com:yctercero/kibana …

9309921

…into exceptions_postff_bugs

fix bug found in review around pagination showing when empty exceptio…

48a2f9c

…n list linked to rule

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

e4da812

…-ref HEAD~1..HEAD --fix'

xcrzx approved these changes Sep 29, 2022

View reviewed changes

yctercero merged commit 49d0858 into elastic:main Sep 29, 2022

kibanamachine added the v8.6.0 label Sep 29, 2022

yctercero deleted the exceptions_postff_bugs branch September 29, 2022 15:20

nastasha-solomon approved these changes Sep 29, 2022

View reviewed changes

kibanamachine mentioned this pull request Sep 29, 2022

[8.5] [Security Solution][Exceptions] - Fixes up some bugs in the all exception items view (#141682) #142237

Merged

yctercero mentioned this pull request Sep 29, 2022

[Security Solution][Exceptions] - Make exceptions read only when displaying deleted rule details #142258

Merged

8 tasks

WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 2, 2022

[Security Solution][Exceptions] - Fixes up some bugs in the all excep…

ab54c1b

…tion items view (elastic#141682) ### Summary Addresses elastic#140709, elastic#141056, elastic#141421, elastic#141042

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Exceptions] - Fixes up some bugs in the all exception items view #141682

[Security Solution][Exceptions] - Fixes up some bugs in the all exception items view #141682

yctercero commented Sep 23, 2022 •

edited by kibanamachine

Loading

elasticmachine commented Sep 23, 2022

yctercero commented Sep 23, 2022

dhurley14 left a comment

xcrzx commented Sep 26, 2022

nastasha-solomon commented Sep 26, 2022

yctercero commented Sep 29, 2022

yctercero commented Sep 29, 2022

kibana-ci commented Sep 29, 2022

xcrzx left a comment

yctercero commented Sep 29, 2022

nastasha-solomon left a comment

nastasha-solomon Sep 29, 2022

yctercero Sep 29, 2022

yctercero Sep 29, 2022

kibanamachine commented Sep 29, 2022

[Security Solution][Exceptions] - Fixes up some bugs in the all exception items view #141682

[Security Solution][Exceptions] - Fixes up some bugs in the all exception items view #141682

Conversation

yctercero commented Sep 23, 2022 • edited by kibanamachine Loading

Summary

Checklist

elasticmachine commented Sep 23, 2022

yctercero commented Sep 23, 2022

dhurley14 left a comment

Choose a reason for hiding this comment

xcrzx commented Sep 26, 2022

nastasha-solomon commented Sep 26, 2022

yctercero commented Sep 29, 2022

yctercero commented Sep 29, 2022

kibana-ci commented Sep 29, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

xcrzx left a comment

Choose a reason for hiding this comment

yctercero commented Sep 29, 2022

nastasha-solomon left a comment

Choose a reason for hiding this comment

nastasha-solomon Sep 29, 2022

Choose a reason for hiding this comment

yctercero Sep 29, 2022

Choose a reason for hiding this comment

yctercero Sep 29, 2022

Choose a reason for hiding this comment

kibanamachine commented Sep 29, 2022

💚 All backports created successfully

Questions ?

yctercero commented Sep 23, 2022 •

edited by kibanamachine

Loading