[Security Solution][Exceptions] - Make exceptions read only when disp…

…laying deleted rule details (#142258) ### Summary Addresses 141899.
elastic · Sep 30, 2022 · f415b3b · f415b3b
1 parent 93b97bf
commit f415b3b
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/...blic/detection_engine/rule_exceptions/components/all_exception_items_table/index.test.tsx b/...blic/detection_engine/rule_exceptions/components/all_exception_items_table/index.test.tsx
@@ -109,6 +109,7 @@ describe('ExceptionsViewer', () => {
             ],
           }}
           listType={ExceptionListTypeEnum.DETECTION}
+          isViewReadOnly={false}
         />
       </TestProviders>
     );
@@ -146,6 +147,7 @@ describe('ExceptionsViewer', () => {
             ],
           }}
           listType={ExceptionListTypeEnum.DETECTION}
+          isViewReadOnly={false}
         />
       </TestProviders>
     );
@@ -183,6 +185,7 @@ describe('ExceptionsViewer', () => {
             ],
           }}
           listType={ExceptionListTypeEnum.ENDPOINT}
+          isViewReadOnly={false}
         />
       </TestProviders>
     );
@@ -226,6 +229,7 @@ describe('ExceptionsViewer', () => {
             ],
           }}
           listType={ExceptionListTypeEnum.DETECTION}
+          isViewReadOnly={false}
         />
       </TestProviders>
     );
@@ -268,6 +272,7 @@ describe('ExceptionsViewer', () => {
           ],
         }}
         listType={ExceptionListTypeEnum.DETECTION}
+        isViewReadOnly={false}
       />
     );
 
@@ -301,6 +306,7 @@ describe('ExceptionsViewer', () => {
           ],
         }}
         listType={ExceptionListTypeEnum.DETECTION}
+        isViewReadOnly={false}
       />
     );
 

diff --git a/...on/public/detection_engine/rule_exceptions/components/all_exception_items_table/index.tsx b/...on/public/detection_engine/rule_exceptions/components/all_exception_items_table/index.tsx
@@ -75,12 +75,15 @@ export interface GetExceptionItemProps {
 interface ExceptionsViewerProps {
   rule: Rule | null;
   listType: ExceptionListTypeEnum;
+  /* Used for when displaying exceptions for a rule that has since been deleted, forcing read only view */
+  isViewReadOnly: boolean;
   onRuleChange?: () => void;
 }
 
 const ExceptionsViewerComponent = ({
   rule,
   listType,
+  isViewReadOnly,
   onRuleChange,
 }: ExceptionsViewerProps): JSX.Element => {
   const { services } = useKibana();
@@ -337,8 +340,8 @@ const ExceptionsViewerComponent = ({
 
   // User privileges checks
   useEffect((): void => {
-    setReadOnly(!canUserCRUD || !hasIndexWrite);
-  }, [setReadOnly, canUserCRUD, hasIndexWrite]);
+    setReadOnly(isViewReadOnly || !canUserCRUD || !hasIndexWrite);
+  }, [setReadOnly, isViewReadOnly, canUserCRUD, hasIndexWrite]);
 
   useEffect(() => {
     if (exceptionListsToQuery.length > 0) {

diff --git a/...ty_solution/public/detections/pages/detection_engine/rules/all/exceptions/translations.ts b/...ty_solution/public/detections/pages/detection_engine/rules/all/exceptions/translations.ts
@@ -157,7 +157,7 @@ export const referenceErrorMessage = (referenceCount: number) =>
 export const EXCEPTION_LIST_SEARCH_PLACEHOLDER = i18n.translate(
   'xpack.securitySolution.detectionEngine.rules.all.exceptions.searchPlaceholder',
   {
-    defaultMessage: 'Search by name or list_id',
+    defaultMessage: 'Search by name or list id',
   }
 );
 

diff --git a/...lugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx b/...lugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx
@@ -871,6 +871,7 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
                     rule={rule}
                     listType={ExceptionListTypeEnum.DETECTION}
                     onRuleChange={refreshRule}
+                    isViewReadOnly={!isExistingRule}
                     data-test-subj="exceptionTab"
                   />
                 </Route>
@@ -881,6 +882,7 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
                     rule={rule}
                     listType={ExceptionListTypeEnum.ENDPOINT}
                     onRuleChange={refreshRule}
+                    isViewReadOnly={!isExistingRule}
                     data-test-subj="endpointExceptionsTab"
                   />
                 </Route>