Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: merge duplicate spikeAnalysisTable components #141116

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 20, 2022

Summary

This PR removes the SpikeAnalysisTableExpandedRow component and uses the SpikeAnalysisTable component as they were almost exactly the same. The small difference has been moved to the SpikeAnalysisTable component.

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Sep 20, 2022
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner September 20, 2022 15:17
@alvarezmelissa87 alvarezmelissa87 added release_note:skip Skip the PR/issue when compiling release notes v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml labels Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peteharverson
Copy link
Contributor

Adding for reference, as this happens on main too, but here expand / collapse works on the wrong row:

log_spikes_table_expand

@qn895
Copy link
Member

qn895 commented Sep 20, 2022

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra
Copy link
Contributor

@peteharverson It's a known issue, we can only fix it once this PR is merged, it introduces unique ids for the groups which is required to make the row expansions work properly.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 499 498 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 760.5KB 755.4KB -5.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 130a8cd into elastic:main Sep 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-aiops-merge-duplicate-component branch September 20, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants