Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Support table hovering with main chart sync on group level #141099

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 20, 2022

Summary

Related meta issue: #138117

This PR:

  • merges duplicate SpikeAnalysisTable components
  • adds table hovering at group level for main chart sync functionality

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Sep 20, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 20, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 499 498 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 759.5KB 754.6KB -4.9KB
Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 7 6 -1
total -2

ESLint disabled line counts

id before after diff
apm 81 79 -2
observability 45 44 -1
securitySolution 408 404 -4
synthetics 59 53 -6
ux 10 9 -1
total -14

Total ESLint disabled count

id before after diff
apm 95 92 -3
observability 52 50 -2
securitySolution 480 476 -4
synthetics 65 59 -6
ux 13 12 -1
total -16

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

/>
),
render: (_, { histogram, fieldName, fieldValue }) => {
if (!histogram) return NOT_AVAILABLE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? The chartData prop for the MiniHistogram component is optional. Returning like this will also not trigger isLoading for the mini histogram component.

@alvarezmelissa87
Copy link
Contributor Author

Closing in lieu of #141116 and #141138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants