[ML] Explain Log Rate Spikes: add main chart sync on row hover at group level #141138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
v8.5.0
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
Closed
8 tasks
…-ref HEAD~1..HEAD --fix'
walterra
requested changes
Sep 20, 2022
Comment on lines
53
to
60
| const groupFilter = []; | ||
| if (selectedGroup) { | ||
| for (const fieldName in selectedGroup.group) { | ||
| if (selectedGroup.group.hasOwnProperty(fieldName)) { | ||
| groupFilter.push({ term: { [fieldName]: selectedGroup.group[fieldName] } }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This needs to consider repeatedValues like this:
const groupFilter = [];
if (selectedGroup) {
const allItems = { ...selectedGroup.group, ...selectedGroup.repeatedValues };
for (const fieldName in allItems) {
if (allItems.hasOwnProperty(fieldName)) {
groupFilter.push({ term: { [fieldName]: allItems[fieldName] } });
}
}
}
There was a problem hiding this comment.
Updated in 655ffec
Comment on lines
81
to
85
| filterCriteria.push({ | ||
| bool: { | ||
| must_not: [...groupFilter], | ||
| }, | ||
| }); |
There was a problem hiding this comment.
must_not is OR by default, to get groupFilter treated with AND it needs to be nested in a bool filter again:
filterCriteria.push({
bool: {
must_not: [
{
bool: {
filter: [...groupFilter],
},
},
],
},
});
There was a problem hiding this comment.
Updated in 655ffec
peteharverson
approved these changes
Sep 20, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for table hovering with main chart sync on group level
Checklist
Delete any items that are not applicable to this PR.