Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain Log Rate Spikes: Add mini histograms to grouped results table. #141065

Merged
merged 7 commits into from
Sep 20, 2022
Merged

[ML] Explain Log Rate Spikes: Add mini histograms to grouped results table. #141065

merged 7 commits into from
Sep 20, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 20, 2022 •
edited
Loading

Summary

Part of #138117.

  • Adds mini histograms to grouped results table.
  • Fixes row expansion issue where expanded row could show up under wrong row.

image

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis labels Sep 20, 2022
@walterra walterra self-assigned this Sep 20, 2022
@walterra walterra requested a review from a team as a code owner September 20, 2022 12:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Sep 20, 2022
Merged
1 task
@peteharverson
Copy link
Contributor

This seems a strange result - the mini histogram in the top row doesn't indicate any (orange) spikes for the deviation:

image

The expanded row info is also wrong - device_os_version value is different in the grouped row to the expanded row.

peteharverson
peteharverson approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and overall LGTM.

We should investigate the result shown in #141065 (comment) separately.

alvarezmelissa87
alvarezmelissa87 reviewed Sep 20, 2022
View reviewed changes
...plugins/aiops/public/components/explain_log_rate_spikes/explain_log_rate_spikes_analysis.tsx Outdated
};
});
return {
id: index,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the id here can now be set to the group's id coming on the backend - this should fix the expanded row bug - I can fix this in a follow up so this can just go in but wanted to point it out 👍 Thanks, @walterra

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@peteharverson
Copy link
Contributor

Confirmed that the change in 87c5a0d fixed the issue I was seeing in #141065 (comment)

image

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ml-agg-utils 40 44 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 755.4KB 756.3KB +976.0B
Unknown metric groups

API count

id before after diff
@kbn/ml-agg-utils 59 64 +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 1598523 into elastic:main Sep 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
@walterra walterra deleted the ml-aiops-grouping-histogram branch September 20, 2022 19:23
@walterra walterra mentioned this pull request Sep 21, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @peteharverson @kibana-ci @alvarezmelissa87 @kibanamachine