Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 302 on /favicon.ico #137294

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Jul 27, 2022

Fixes #31683

@elastic/kibana-operations do you see any drawback in simply adding the missing favicon.ico, so that we avoid the whole conflict?

@gsoldevila gsoldevila added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:fix backport:all-open Backport to all branches that could still receive a release v8.5.0 labels Jul 27, 2022
@gsoldevila gsoldevila requested review from a team as code owners July 27, 2022 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@gsoldevila gsoldevila enabled auto-merge (squash) July 28, 2022 11:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila gsoldevila merged commit a40d241 into elastic:main Jul 28, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 28, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 28, 2022
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.3
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 137294

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 28, 2022
(cherry picked from commit a40d241)

Co-authored-by: Gerard Soldevila <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 28, 2022
(cherry picked from commit a40d241)

Co-authored-by: Gerard Soldevila <[email protected]>
Co-authored-by: Spencer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release bug Fixes for quality problems that affect the customer experience release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.3.3 v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana should NOT return 302 for /favicon.ico
6 participants