Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana should NOT return 302 for /favicon.ico #31683

Closed
vbohata opened this issue Feb 21, 2019 · 4 comments · Fixed by #137294
Closed

Kibana should NOT return 302 for /favicon.ico #31683

vbohata opened this issue Feb 21, 2019 · 4 comments · Fixed by #137294
Assignees
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@vbohata
Copy link

vbohata commented Feb 21, 2019

Describe the feature:
Kibana returns 404 for /favicon.ico if the user is already authenticated. In other case browser receives 302 with redirection to /login?next=%2Ffavicon.ico. It makes problems with Kibana published using some external authenticating proxy because:

  1. If accessing https://kibanaurl with firefox, firefox actually creates 2 requests - one to https://kibanaurl and the second one to https://kibanaurl/favicon.ico
  2. Authenticating proxy returns its login form to the user while returning 302 and 200 for /favicon.ico from backend.
  3. Browser caches 200 for /favicon.ico
  4. After logging in in auth proxy user is redirected to Kibana https://kibanaurl/login?next=%2Ffavicon.ico
  5. User authenticates in Kibana and is redirected by Kibana to https://kibanaurl/favicon.ico which does not exist

Describe a specific use case for the feature:
One of the use case is webseal publishing. See https://www.ibm.com/support/knowledgecenter/ja/SSPREK_6.1.0/com.ibm.itame.doc_6.1/am61_webseal_admin138.htm
It is expected the backend always returns 404 for favicon.ico to fix the firefox behaviour. But currently it is not true for login form of Kibana as it catches /favicon.ico and returns 302 to the browser.

@jbudz jbudz added the Team:Operations Team label for Operations Team label Feb 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 5, 2021
@tylersmalley tylersmalley added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:Operations Team label for Operations Team loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo added bug Fixes for quality problems that affect the customer experience EnableJiraSync labels Mar 17, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Mar 22, 2022
@lukeelmers
Copy link
Member

We could probably do this by allowing unauthenticated access to all ui assets (need to confirm this is okay to do)

https://github.com/elastic/kibana/blob/main/src/core/server/core_app/core_app.ts#L199

@lukeelmers lukeelmers added loe:small Small Level of Effort good first issue low hanging fruit labels Mar 22, 2022
@gsoldevila
Copy link
Contributor

FWIW I think recent browser versions don't request the favicon.ico anymore (tested with Firefox 102 and Chrome 103 in local and cloud).

What about "simply" adding the missing favicon.ico file? This way we don't need to change anything security-wise because the file will actually exist and it will be simply served.

@gsoldevila gsoldevila self-assigned this Jul 27, 2022
@gsoldevila gsoldevila changed the title Kibana should always return 404 for /favicon.ico Kibana should NOT return 302 for /favicon.ico Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants