Skip to content

Commit

Permalink
Fix 302 on /favicon.ico (#137294) (#137461)
Browse files Browse the repository at this point in the history
(cherry picked from commit a40d241)

Co-authored-by: Gerard Soldevila <[email protected]>
Co-authored-by: Spencer <[email protected]>
  • Loading branch information
3 people authored Jul 28, 2022
1 parent 10460c8 commit 0054208
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 0 deletions.
Binary file not shown.
Binary file not shown.
1 change: 1 addition & 0 deletions src/dev/build/tasks/copy_source_task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const CopySource: Task = {
'!src/**/*.{test,test.mocks,mock}.{js,ts,tsx}',
'!src/**/mocks.ts', // special file who imports .mock files
'!src/**/{target,tests,__jest__,test_data,__tests__,__snapshots__,__mocks__,integration_tests,__fixtures__}/**',
'!src/core/server/core_app/assets/favicons/favicon.distribution.ico',
'!src/core/server/core_app/assets/favicons/favicon.distribution.png',
'!src/core/server/core_app/assets/favicons/favicon.distribution.svg',
'!src/test_utils/**',
Expand Down
5 changes: 5 additions & 0 deletions src/dev/build/tasks/replace_favicon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ export const ReplaceFavicon: Task = {
description: 'Replacing favicons with built version',

async run(config, log, build) {
await copy(
config.resolveFromRepo('src/core/server/core_app/assets/favicons/favicon.distribution.ico'),
build.resolvePath('src/core/server/core_app/assets/favicons/favicon.ico')
);

await copy(
config.resolveFromRepo('src/core/server/core_app/assets/favicons/favicon.distribution.png'),
build.resolvePath('src/core/server/core_app/assets/favicons/favicon.png')
Expand Down

0 comments on commit 0054208

Please sign in to comment.