Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip flaky Enter Space test #131835

Merged
merged 4 commits into from
May 10, 2022
Merged

Unskip flaky Enter Space test #131835

merged 4 commits into from
May 10, 2022

Conversation

legrego
Copy link
Member

@legrego legrego commented May 9, 2022 •
edited
Loading

Unskips the "Enter Space" test suite, by improving the resiliency of the function responsible for opening the spaces nav.

Resolves #100570

Flaky Test Runs

Result

  • This test failed twice during the original flaky test runner job (before the fix)
  • This test passed 300 times during the subsequent flaky test runner jobs (after the fix)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 10, 2022
@legrego legrego marked this pull request as ready for review May 10, 2022 10:59
@legrego legrego requested a review from a team as a code owner May 10, 2022 10:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

watson
watson approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Don't we want to backport this to 7.17 as well?

@legrego
Copy link
Member Author

legrego commented May 10, 2022

Don't we want to backport this to 7.17 as well?

Yep good call!

@legrego legrego merged commit 7df8edf into elastic:main May 10, 2022
@legrego legrego deleted the spaces/flaky-enter-test branch May 10, 2022 11:59
@legrego legrego mentioned this pull request May 10, 2022
Merged
@legrego legrego added the auto-backport Deprecated - use backport:version if exact versions are needed label May 10, 2022
kibanamachine pushed a commit that referenced this pull request May 10, 2022
@legrego
Unskip flaky Enter Space test (#131835)
8e714cf 
* Unskip flaky test

* re-include firefox

* Flakyness attempt

* lint

(cherry picked from commit 7df8edf)
@kibanamachine kibanamachine mentioned this pull request May 10, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 10, 2022
@kibanamachine @legrego
Unskip flaky Enter Space test (#131835) (#131908)
09f0954 
* Unskip flaky test

* re-include firefox

* Flakyness attempt

* lint

(cherry picked from commit 7df8edf)

Co-authored-by: Larry Gregory <[email protected]>
@legrego legrego mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.17.4 v8.3.0
Projects
None yet
Milestone
No milestone
5 participants
@legrego @kibana-ci @elasticmachine @kibanamachine @watson