Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip flaky Enter Space test #131835

Merged
merged 4 commits into from
May 10, 2022
Merged

Unskip flaky Enter Space test #131835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df8ad1d
Unskip flaky test
legrego May 9, 2022
66d8123
re-include firefox
legrego May 9, 2022
dec1bc8
Flakyness attempt
legrego May 9, 2022
7008af8
lint
legrego May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions x-pack/test/functional/apps/spaces/enter_space.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@ export default function enterSpaceFunctonalTests({
const esArchiver = getService('esArchiver');
const PageObjects = getPageObjects(['security', 'spaceSelector']);

// FLAKY: https://github.com/elastic/kibana/issues/99879
describe.skip('Enter Space', function () {
// FLAKY: https://github.com/elastic/kibana/issues/100570
// These tests fail very intermittently in Firefox. Skip Firefox testing until resolved.
// this.tags('includeFirefox');
describe('Enter Space', function () {
this.tags('includeFirefox');
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/spaces/enter_space');
await PageObjects.security.forceLogout();
Expand Down
5 changes: 4 additions & 1 deletion x-pack/test/functional/page_objects/space_selector_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export class SpaceSelectorPageObject extends FtrService {

async openSpacesNav() {
this.log.debug('openSpacesNav()');
return await this.testSubjects.click('spacesNavSelector');
return await this.retry.try(async () => {
await this.testSubjects.click('spacesNavSelector');
await this.find.byCssSelector('#headerSpacesMenuContent');
});
}

async clickManageSpaces() {
Expand Down