Skip to content

Commit

Permalink
Unskip flaky Enter Space test (#131835) (#131908)
Browse files Browse the repository at this point in the history
* Unskip flaky test

* re-include firefox

* Flakyness attempt

* lint

(cherry picked from commit 7df8edf)

Co-authored-by: Larry Gregory <[email protected]>
  • Loading branch information
kibanamachine and legrego authored May 10, 2022
1 parent 8c6081f commit 09f0954
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
7 changes: 2 additions & 5 deletions x-pack/test/functional/apps/spaces/enter_space.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@ export default function enterSpaceFunctonalTests({
const esArchiver = getService('esArchiver');
const PageObjects = getPageObjects(['security', 'spaceSelector']);

// FLAKY: https://github.com/elastic/kibana/issues/99879
describe.skip('Enter Space', function () {
// FLAKY: https://github.com/elastic/kibana/issues/100570
// These tests fail very intermittently in Firefox. Skip Firefox testing until resolved.
// this.tags('includeFirefox');
describe('Enter Space', function () {
this.tags('includeFirefox');
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/spaces/enter_space');
await PageObjects.security.forceLogout();
Expand Down
5 changes: 4 additions & 1 deletion x-pack/test/functional/page_objects/space_selector_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export class SpaceSelectorPageObject extends FtrService {

async openSpacesNav() {
this.log.debug('openSpacesNav()');
return await this.testSubjects.click('spacesNavSelector');
return await this.retry.try(async () => {
await this.testSubjects.click('spacesNavSelector');
await this.find.byCssSelector('#headerSpacesMenuContent');
});
}

async clickManageSpaces() {
Expand Down

0 comments on commit 09f0954

Please sign in to comment.