Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndexManagement - IngestPipelines] Remove leftover axios dependencies #130089

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

sabarasaba
Copy link
Member

Partially addresses #127966

Summary

When #128171 and #128467 got merged, there were a few instances of axios that I forgot to remove. This PR addresses that!

@sabarasaba sabarasaba added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management v8.3.0 labels Apr 13, 2022
@sabarasaba sabarasaba self-assigned this Apr 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba marked this pull request as ready for review April 13, 2022 11:04
@sabarasaba sabarasaba requested a review from a team as a code owner April 13, 2022 11:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! LGTM.

@sabarasaba sabarasaba merged commit aa14fd0 into elastic:main Apr 13, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 13, 2022
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Apr 13, 2022
elastic#130089)

* Remove last axios dep from ingest pipelines

* Remove last axios dep from index management

* commit using @elastic.co

* Fix linter errors

(cherry picked from commit aa14fd0)

# Conflicts:
#	x-pack/plugins/index_management/__jest__/components/index_table.test.js
sabarasaba added a commit that referenced this pull request Apr 13, 2022
#130089) (#130111)

* Remove last axios dep from ingest pipelines

* Remove last axios dep from index management

* commit using @elastic.co

* Fix linter errors

(cherry picked from commit aa14fd0)

# Conflicts:
#	x-pack/plugins/index_management/__jest__/components/index_table.test.js

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants