-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IndexManagement - IngestPipelines] Remove leftover axios dependencies #130089
Merged
sabarasaba
merged 4 commits into
elastic:main
from
sabarasaba:remove_leftover_axios_deps
Apr 13, 2022
Merged
[IndexManagement - IngestPipelines] Remove leftover axios dependencies #130089
sabarasaba
merged 4 commits into
elastic:main
from
sabarasaba:remove_leftover_axios_deps
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Index Management
Index and index templates UI
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Ingest Node Pipelines
Ingest node pipelines management
v8.3.0
labels
Apr 13, 2022
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: cc @sabarasaba |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
alisonelizabeth
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! LGTM.
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Apr 13, 2022
elastic#130089) * Remove last axios dep from ingest pipelines * Remove last axios dep from index management * commit using @elastic.co * Fix linter errors (cherry picked from commit aa14fd0) # Conflicts: # x-pack/plugins/index_management/__jest__/components/index_table.test.js
sabarasaba
added a commit
that referenced
this pull request
Apr 13, 2022
#130089) (#130111) * Remove last axios dep from ingest pipelines * Remove last axios dep from index management * commit using @elastic.co * Fix linter errors (cherry picked from commit aa14fd0) # Conflicts: # x-pack/plugins/index_management/__jest__/components/index_table.test.js Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Index Management
Index and index templates UI
Feature:Ingest Node Pipelines
Ingest node pipelines management
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #127966
Summary
When #128171 and #128467 got merged, there were a few instances of axios that I forgot to remove. This PR addresses that!