Get rid of axios
dependency in the platform deployment management tests.
#127966
Closed
7 tasks done
Labels
NeededFor:Operations
NeededFor:Security
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
technical debt
Improvement of the software architecture and operational architecture
triage_needed
Summary
In #111655 (comment) we're trying to upgrade
axios
package, but are blocked because of the followingaxios
usage in the tests (axios
just happened to have methods signature similar toHttpSetup
, but it's technically incorrect and quite fragile):The path forward is to switch tests to use
HttpSetup
mock instead ofaxios
+sinon
server mock. There is an example and reference implementation in theUpgrade Assistant
tests, see this pull request.If you have any questions or don't have enough capacity to update the tests, please ping me and I'll try to help out.
Here is the list of the plugins that need to be updated (if I didn't miss anything):
x-pack/plugins/cross_cluster_replication
[CCR] Removeaxios
dependency in tests #128148x-pack/plugins/index_lifecycle_management
[ILM] Removeaxios
dependency in tests #129009x-pack/plugins/index_management
[IM] Removeaxios
dependency in tests #128171x-pack/plugins/ingest_pipelines
[Ingest Pipelines] Removeaxios
dependency in tests #128467x-pack/plugins/remote_clusters
[Remote Clusters] Removeaxios
dependency in tests #128590x-pack/plugins/snapshot_restore
[Snapshot & Restore] Removeaxios
dependency in tests #128614x-pack/plugins/watcher
[Watcher] Removeaxios
dependency in tests #128765IMPORTANT: we have to backport
axios
upgrade to7.17.x
and hence updated tests should be backported to the7.17
branch as well.The text was updated successfully, but these errors were encountered: