[CCR] Remove axios dependency in tests
#128148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:CCR and Remote Clusters
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
7 tasks
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
alisonelizabeth
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
LGTM. Thanks for fixing this @sabarasaba! Did not run tests locally.
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Mar 22, 2022
* Start refactoring test * Finish refactoring rest of tests (cherry picked from commit 7b545b0)
sabarasaba
added a commit
that referenced
this pull request
Mar 22, 2022
* Start refactoring test * Finish refactoring rest of tests (cherry picked from commit 7b545b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #127966
Summary
In order to upgrade the axios dependency in kibana(see: #111655) we need to switch the tests from this app to use HttpSetup mock instead of axios + sinon server mock, which is technically incorrect but axios just happened to have methods signature similar to HttpSetup.