[Ingest Pipelines] Remove axios dependency in tests
#128467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Team:Kibana Management
This was referenced Mar 24, 2022
|
@elasticmachine merge upstream |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
yuliacech
reviewed
Mar 29, 2022
| '/api/ingest_pipelines/simulate' | ||
| expect(httpSetup.post).toHaveBeenLastCalledWith( | ||
| `${API_BASE_PATH}/simulate`, | ||
| expect.anything() |
There was a problem hiding this comment.
nit: I don't think that would test for 2 different calls to the simulate API. You might want to use toHaveBeenCalledTimes or toHaveBeenNthCalledWith
There was a problem hiding this comment.
nice catch!, ill patch it up!
yuliacech
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Thanks a lot for updating these tests, @sabarasaba! Changes LGTM 👍
There is quite some boilerplate for mock setup but I've seen your discussion about keeping that implementation in each plugin separately for now.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Mar 30, 2022
* Refactor main cits * commit using @elastic.co * Finish refactoring pipeline_editor cits * Carefully access prop * Fix hardcoded props * Fix ts issues * Add back missing attr * Address CR changes (cherry picked from commit d869a7f) # Conflicts: # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/http_requests.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_clone.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_create.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_create_from_csv.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_edit.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/ingest_pipelines_create_from_csv.test.tsx
sabarasaba
added
backport:skip
sabarasaba
added a commit
that referenced
this pull request
Mar 30, 2022
) * Refactor main cits * commit using @elastic.co * Finish refactoring pipeline_editor cits * Carefully access prop * Fix hardcoded props * Fix ts issues * Add back missing attr * Address CR changes (cherry picked from commit d869a7f) # Conflicts: # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/http_requests.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_clone.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_create.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_create_from_csv.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/helpers/pipelines_edit.helpers.ts # x-pack/plugins/ingest_pipelines/__jest__/client_integration/ingest_pipelines_create_from_csv.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #127966
Summary
In order to upgrade the axios dependency in kibana(see: #111655) we need to switch the tests from this app to use HttpSetup mock instead of axios + sinon server mock, which is technically incorrect but axios just happened to have methods signature similar to HttpSetup.
Note: There's a bunch of CIT's for
pipeline_editorthat live inx-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/__jest__, ideally thesetup_environment.tsandhttp_request.tsfiles could be refactored into just one. I'll create an issue for dealing with that