Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aggs] remove toAngularJson #127267

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Mar 9, 2022

Summary

The security team suggested removing reference to angular because it may rise security-related inquiries. The team suggested backporting back to 7.17.

Since Angular was removed a while ago, this change shouldn't affect functionality.

Just to be clear for other readers, we have no reason to believe this code is vulnerable at all. We are just removing dead code that had raised a question.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 534 533 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 457.1KB 456.6KB -485.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes v7.17.2 v8.0.2 v8.1.1 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed Team:AppServicesSv labels Mar 9, 2022
@Dosant Dosant requested a review from jportner March 9, 2022 15:27
@Dosant Dosant marked this pull request as ready for review March 9, 2022 15:27
@Dosant Dosant requested a review from a team as a code owner March 9, 2022 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Just to be clear for other readers, we have no reason to believe this code is vulnerable at all. We are just removing dead code that had raised a question.

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@Dosant Dosant merged commit 51304a3 into elastic:main Mar 10, 2022
kibanamachine pushed a commit that referenced this pull request Mar 10, 2022
(cherry picked from commit 51304a3)
kibanamachine pushed a commit that referenced this pull request Mar 10, 2022
(cherry picked from commit 51304a3)
kibanamachine pushed a commit that referenced this pull request Mar 10, 2022
(cherry picked from commit 51304a3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
7.17
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 10, 2022
(cherry picked from commit 51304a3)

Co-authored-by: Anton Dosov <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 10, 2022
(cherry picked from commit 51304a3)

Co-authored-by: Anton Dosov <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 10, 2022
…move-pdf-generation-to-screenshotting

* 'main' of github.com:elastic/kibana: (62 commits)
  [Lens] Drop partial buckets option (elastic#127153)
  chore(NA): remove unused translation xpack.ml.management.jobsSpacesList.objectNoun from fr-FR (elastic#127457)
  Add data to user details page (elastic#127019)
  [Fleet] Make upload and registry package info consistent (elastic#126915)
  [Reporting] Capture browser errors (elastic#127135)
  Initial readme commit with some stub articles (elastic#127420)
  skip flaky suite (elastic#121482)
  skip flaky suite (elastic#127416)
  Tests to ensure Kibana is handling multi-space import of saved objects correctly (elastic#127229)
  [Aggs] remove toAngularJson (elastic#127267)
  [i18n] Integrate 8.2.0 Translations (elastic#127309)
  [Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts (elastic#126685)
  [Kibana React] Fix Page Template `solutionNav` propagation (elastic#127140)
  [Cases] Export getRelatedCases API from cases client (elastic#127065)
  [Cloud Posture]add support for sorting benchmark page (elastic#126983)
  [User experience] Fix filters for the app (elastic#127295)
  [Fleet] Fix timeserie dimension mapping (elastic#127328)
  [data view mgmt] fix data view name wrap (elastic#127319)
  [kbn/optimizer] extract string diffing logic (elastic#127394)
  [ResponseOps] Add pagination and sorting to the alerts search strategy (elastic#126813)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/common/errors.ts
#	x-pack/plugins/screenshotting/common/index.ts
#	x-pack/plugins/screenshotting/server/screenshots/observable.ts
@Dosant Dosant removed the v8.0.2 label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.17.2 v8.1.1 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants