Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to ensure Kibana is handling multi-space import of saved objects correctly #127229

Merged
merged 15 commits into from
Mar 10, 2022
Merged

Tests to ensure Kibana is handling multi-space import of saved objects correctly #127229

merged 15 commits into from
Mar 10, 2022

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Mar 8, 2022 •
edited
Loading

Tests for #126940

@bhavyarm bhavyarm self-assigned this Mar 8, 2022
@bhavyarm bhavyarm added v8.2.0 test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes Feature:Saved Objects auto-backport Deprecated - use backport:version if exact versions are needed v8.1.1 Feature:Saved Objects Management labels Mar 8, 2022
@bhavyarm bhavyarm requested review from LeeDr and flash1293 March 8, 2022 23:40
@bhavyarm bhavyarm changed the title Tests to ensure Kibana is handling multi-space import saved objects correctlt Tests to ensure Kibana is handling multi-space import of saved objects correctly Mar 8, 2022
@bhavyarm bhavyarm marked this pull request as ready for review March 9, 2022 01:30
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 9, 2022

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 9, 2022

Flaky test run - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/239

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 9, 2022

Thanks @flash1293 :)

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 9, 2022

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 9, 2022

@elasticmachine merge upstream

LeeDr
LeeDr approved these changes Mar 10, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one comment left over.

x-pack/test/functional/apps/saved_objects_management/multi_space_import.ts Outdated Show resolved Hide resolved
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/252 flaky test runner with all the changes - green build.

@bhavyarm bhavyarm merged commit a4babea into elastic:main Mar 10, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Mar 10, 2022
@bhavyarm
Tests to ensure Kibana is handling multi-space import of saved object…
12c37b0 
…s correctly (#127229)

(cherry picked from commit a4babea)
@bhavyarm bhavyarm mentioned this pull request Mar 10, 2022
Closed
kibanamachine added a commit that referenced this pull request Mar 10, 2022
@kibanamachine @bhavyarm
Tests to ensure Kibana is handling multi-space import of saved object…
af9ade3 
…s correctly (#127229) (#127451)

(cherry picked from commit a4babea)

Co-authored-by: Bhavya RM <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 10, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into screenshotting/…
6cb4725 
…move-pdf-generation-to-screenshotting

* 'main' of github.com:elastic/kibana: (62 commits)
  [Lens] Drop partial buckets option (elastic#127153)
  chore(NA): remove unused translation xpack.ml.management.jobsSpacesList.objectNoun from fr-FR (elastic#127457)
  Add data to user details page (elastic#127019)
  [Fleet] Make upload and registry package info consistent (elastic#126915)
  [Reporting] Capture browser errors (elastic#127135)
  Initial readme commit with some stub articles (elastic#127420)
  skip flaky suite (elastic#121482)
  skip flaky suite (elastic#127416)
  Tests to ensure Kibana is handling multi-space import of saved objects correctly (elastic#127229)
  [Aggs] remove toAngularJson (elastic#127267)
  [i18n] Integrate 8.2.0 Translations (elastic#127309)
  [Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts (elastic#126685)
  [Kibana React] Fix Page Template `solutionNav` propagation (elastic#127140)
  [Cases] Export getRelatedCases API from cases client (elastic#127065)
  [Cloud Posture]add support for sorting benchmark page (elastic#126983)
  [User experience] Fix filters for the app (elastic#127295)
  [Fleet] Fix timeserie dimension mapping (elastic#127328)
  [data view mgmt] fix data view name wrap (elastic#127319)
  [kbn/optimizer] extract string diffing logic (elastic#127394)
  [ResponseOps] Add pagination and sorting to the alerts search strategy (elastic#126813)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/common/errors.ts
#	x-pack/plugins/screenshotting/common/index.ts
#	x-pack/plugins/screenshotting/server/screenshots/observable.ts
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Mar 10, 2022
@bhavyarm
Tests to ensure Kibana is handling multi-space import of saved object…
0a1cf5a 
…s correctly (elastic#127229)

(cherry picked from commit a4babea)
@bhavyarm bhavyarm mentioned this pull request Mar 10, 2022
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 14, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 left review comments

@LeeDr LeeDr LeeDr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Saved Objects Management Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.0.2 v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @kibana-ci @kibanamachine @flash1293 @LeeDr