[Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts #126685

dasansol92 · 2022-03-02T15:24:54Z

Summary

Pending to add all unit tests for generic components.
Pending to remove old code (maybe will move this to a subsequent PR).
Pending to add host isolation exceptions privileges checks.
Pending to use url hook to get url params instead of redux.

It includes a generic component that renders policy artifact tab depending on artifact type. This component will allow us add features easily and faster across all tabs and add new artifact types.

Usage within PolicyTabs component:

          <PolicyArtifactsLayout
              // The policy item 
              policyItem={policyItem}
              // A function that returns the desired api client instance. Must be a function since tabs are rendered when component mounts and we want to get a new instance when focusing the desired tab.
              getExceptionsListApiClient={() => TrustedAppsApiClient.getInstance(http)}
              // A set of required and optional labels. [See this for reference](https://github.com/elastic/kibana/pull/126685/files#diff-c9deb5f70603c5052d77835dc4307e15f97fae44724d9b3270bf78acbc1688c5)
              labels={POLICY_ARTIFACT_TRUSTED_APPS_LABELS}
              // An array of fields exceptions are searchable on
              searcheableFields={TRUSTED_APPS_SEARCHABLE_FIELDS}
              // A function to get the artifact list url path
              getArtifactPath={getTrustedAppsListPath}
              // A function to get the policy artifact tab url path
              getPolicyArtifactsPath={getPolicyDetailsArtifactsListPath}
              // An optional boolean to define extra privileges (for host isolation exceptions for example)
              externalPrivileges={aBooleanToCheckExternalPrivileges}
            />

For maintainers

This was checked for breaking API changes and was labeled appropriately

…hing

…component_to_be_used_for_all_of_our_artifacts-3173

paul-tavares

some initial feedback. Did not get very far (stoped at policy_artifacts_layout.tsx). will pick it up again tomorrow

x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/constants.ts

...tion/public/management/pages/policy/view/artifacts/empty/use_policy_artifacts_empty_hooks.ts

…an artifact_layout unit test

…component_to_be_used_for_all_of_our_artifacts-3173

elasticmachine · 2022-03-07T15:58:26Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

paul-tavares · 2022-03-08T17:50:56Z

...public/management/pages/policy/view/artifacts/delete_modal/policy_artifacts_delete_modal.tsx

+        onSettled: () => {
+          queryClient.invalidateQueries(['list', apiClient]);
+          onCancel();
+        },


Just want to make sure this code is correct. As I understand it, onSettled is called everytime - regardless of success or error. So even if it errors, you are invalidating queries and you are calling onCancel() (why call onCancel on a failure?).

You are right, we should keep the query cache and don't close the modal if something has failed. Thanks!

paul-tavares · 2022-03-08T17:52:06Z

...public/management/pages/policy/view/artifacts/delete_modal/policy_artifacts_delete_modal.tsx

+  policyName: string;
+  apiClient: ExceptionsListApiClient;
+  exception: ExceptionListItemSchema;
+  onCancel: () => void;


Looking at the code below, I wonder if this should be named onClose. It seems to be used in both success and failure cases and when user cancels the modal

paul-tavares · 2022-03-08T17:52:43Z

...public/management/pages/policy/view/artifacts/delete_modal/policy_artifacts_delete_modal.tsx

+    const handleModalConfirm = useCallback(() => {
+      const modifiedException = {
+        ...exception,
+        tags: exception.tags.filter((tag) => tag !== `policy:${policyId}`),


can you use the const for the by policy prefix instead of hardcoding policy:

paul-tavares · 2022-03-08T17:56:57Z

...ty_solution/public/management/pages/policy/view/artifacts/flyout/policy_artifacts_flyout.tsx

+      },
+      onSettled: () => {
+        queryClient.invalidateQueries(['list', apiClient]);
+        onClose();


paul-tavares · 2022-03-08T17:59:36Z

...lution/public/management/pages/policy/view/artifacts/layout/policy_artifacts_layout.test.tsx

+let mockedApi: ReturnType<typeof eventFiltersListQueryHttpMock>;
+let history: AppContextTestRender['history'];
+
+const eventFiltersLabels = {


can you convert this to a function that returns the object, so that we avoid sharing state between tests

paul-tavares · 2022-03-08T18:12:56Z

...curity_solution/public/management/pages/policy/view/artifacts/list/policy_artifacts_list.tsx

+      [navigateCallback]
+    );
+
+    const handleOnExpandCollapse: ArtifactCardGridProps['onExpandCollapse'] = ({


for this one and more below - should wrap them in useCallback()

paul-tavares · 2022-03-08T18:14:20Z

...curity_solution/public/management/pages/policy/view/artifacts/list/policy_artifacts_list.tsx

+    }, [artifacts?.data.length, labels]);
+
+    const artifactCardPolicies = useEndpointPoliciesToArtifactPolicies(policiesRequest.data?.items);
+    const provideCardProps: ArtifactCardGridProps['cardComponentProps'] = (artifact) => {


I have a hook in my ArtifactListPage that provides this. Wondering if we should promote it and just reuse here?

https://github.com/elastic/kibana/blob/f4a13a883b71c53aba8663ee52c33091375d5d83/x-pack/plugins/security_solution/public/management/components/artifact_list_page/hooks/use_artifact_card_props_provider.ts

Is this one useArtifactCardPropsProvider? I think we should do a bit of refactor then to add the privilege checks conditions.

yeah, that one. Let's hold off on using them, since some refactoring is needed.

paul-tavares · 2022-03-08T18:24:24Z

...ins/security_solution/public/management/pages/policy/view/tabs/event_filters_translations.ts

+      defaultMessage: 'Error while attempt to remove event filter',
+    }
+  ),
+  flyoutWarningCalloutMessage: i18n.translate(


Wondering if this one should be a function that accepts on input the max number of items to display - since you created a const. then use that in the message

paul-tavares · 2022-03-08T18:26:53Z

x-pack/plugins/security_solution/public/management/pages/policy/view/tabs/policy_tabs.tsx

+              getExceptionsListApiClient={() => TrustedAppsApiClient.getInstance(http)}
+              searcheableFields={[...TRUSTED_APPS_SEARCHABLE_FIELDS]}


should these be memoized in order to avoid unnecessary re-renders?

(same comment below)

I don't think so, this is from a static import. I'm destructuring it because it's a readonly type. I can just define it as readonly on the component itself.

Ok. Just realize that because you are passing a new function everytime to getExceptionsListApiClient and a new Array to searcheableFields, the component will always trigger a re-render (props strict equality ( === ) will report false)

oh yes, we can use useCallback for the getExceptionsListApiClient function

and maybe use instead of creating a new array and spreading the values, just cast the type?

the searchableFields destructured array is fixed in this commit d99ba65

About the getExceptionsListApiClient, all of this code is inside a useMemo, do you think it's necessary to have functions outside using useCallback?

paul-tavares · 2022-03-08T18:31:12Z

...s/security_solution/public/management/services/exceptions_list/exceptions_list_api_client.ts

-    if (!ExceptionsListApiClient.instance.has(listId)) {
+    if (
+      !ExceptionsListApiClient.instance.has(listId) ||
+      ExceptionsListApiClient.instance.get(listId)?.http !== http


I don't think this is working. http is not public on the instance.
Maybe (instead of exposing http on the class, we add a method - something like: isHttp(coreHtttp): boolean { return this.http === coreHttp}

Also, can you add a test for it.

parkiino · 2022-03-09T06:38:06Z

...security_solution/public/management/pages/policy/view/artifacts/delete_modal/translations.ts

+  deleteModalErrorMessage: i18n.translate(
+    'xpack.securitySolution.endpoint.policy.artifacts.list.removeDialog.errorToastTitle',
+    {
+      defaultMessage: 'Error while attempt to remove artifact',


I think this and all the other translations with attempt should be attempting

…component_to_be_used_for_all_of_our_artifacts-3173

paul-tavares

Left a few comments, but this looks good to go from my perspective.

🚢 it

paul-tavares · 2022-03-09T13:50:20Z

x-pack/plugins/security_solution/public/management/hooks/artifacts/use_list_artifact.tsx

-    page: number;
-    perPage: number;
-    policies: string[];
+    filter?: string;


Sooooo... I changed this hook in my PR as well and:

Moved the order of the input props around to: apiClient, options, searchableFields and then query options.

made searchableFields optional -defaults to the DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS

made options be a Partial<> instead of forcing the user to define every attribute. Looks like this in mine:

export function useListArtifact( exceptionListApiClient: ExceptionsListApiClient, options: Partial<{ filter: string; page: number; perPage: number; policies: string[]; }> = {}, searchableFields: MaybeImmutable<string[]> = DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS, customQueryOptions: UseQueryOptions<FoundExceptionListItemSchema, HttpFetchError> = {} ): QueryObserverResult<FoundExceptionListItemSchema, HttpFetchError> { const { filter = '', page = MANAGEMENT_DEFAULT_PAGE + 1, perPage = MANAGEMENT_DEFAULT_PAGE_SIZE, policies, } = options;

I made these changes in order to keep the hook's primary responsibility (to get a list of data out) simple and down to a minimal set of input args needed to use it.

Ref: https://github.com/elastic/kibana/pull/126400/files#diff-01c4c157be58054f3b6dc1977f5bba98738cc8461f4f6d15b97710b3f4b12759R17

done: 63f8f9a

paul-tavares · 2022-03-09T13:53:56Z

x-pack/plugins/security_solution/public/management/hooks/artifacts/use_list_artifact.tsx

+    filter?: string;
+    page?: number;
+    perPage?: number;
+    policies?: string[];


I'm wondering if we should also support a string for policies so that it is easier to just pass in the URL param value. that being said, once I work on a better URL param parser hook, this might be a non-issue as that "parser" would likely take care of it.

At this hook level I think is better to have an array and not a string. This can avoid us having wrong strings wit wrong structures coming from url. Agree this can change once we have a policy hook for parsing

paul-tavares · 2022-03-09T13:55:20Z

x-pack/plugins/security_solution/public/management/hooks/artifacts/use_list_artifact.tsx

+    FoundExceptionListItemSchema,
+    HttpFetchError
+  > = DEFAULT_OPTIONS,
+  customQueryIds: string[] = []


You are introducing this just so that you can invalidate queries?

paul-tavares · 2022-03-09T14:04:41Z

...s/security_solution/public/management/services/exceptions_list/exceptions_list_api_client.ts

-    if (!ExceptionsListApiClient.instance.has(listId)) {
+    if (
+      !ExceptionsListApiClient.instance.has(listId) ||
+      !ExceptionsListApiClient.instance.get(listId)?.isHttp(http)


I don't think you need the ? here now that you added the method.

ExceptionsListApiClient.instance.get(listId) can be undefined at this point

Ohhh. I see now. TS is not smart enough to know that .has() being true will cause .get() to return the instance.

…ctions inside a useCallback

ashokaditya

Looks good to 🚢 . I have a suggestion for file renames and some minor typos.

ashokaditya · 2022-03-09T13:15:26Z

...tion/public/management/pages/policy/view/artifacts/empty/use_policy_artifacts_empty_hooks.ts

 import { APP_UI_ID } from '../../../../../../../common/constants';
+import { EventFiltersPageLocation } from '../../../../event_filters/types';
+import { TrustedAppsListPageLocation } from '../../../../trusted_apps/state';


For consistency, I would suggest we remove this folder state and move the files out and rename them like the other artifacts.

will do this in a subsequent pr if you don't mind 🙂

ashokaditya · 2022-03-09T13:42:05Z

...ty_solution/public/management/pages/policy/view/artifacts/flyout/policy_artifacts_flyout.tsx

+      if (!artifacts) {
+        return;
+      }
+      const artifactssToUpdate: ExceptionListItemSchema[] = [];


nitpick: typo

Suggested change

const artifactssToUpdate: ExceptionListItemSchema[] = [];

const artifactsToUpdate: ExceptionListItemSchema[] = [];

ashokaditya · 2022-03-09T13:42:46Z

...ty_solution/public/management/pages/policy/view/artifacts/flyout/policy_artifacts_flyout.tsx

+        return null;
+      }
+
+      // there are no artifacts assignable to this policy


ashokaditya · 2022-03-09T13:42:56Z

...ty_solution/public/management/pages/policy/view/artifacts/flyout/policy_artifacts_flyout.tsx

+        );
+      }
+
+      // there are no results for the current search


ashokaditya · 2022-03-09T13:44:22Z

...ty_solution/public/management/pages/policy/view/artifacts/flyout/policy_artifacts_flyout.tsx

+interface PolicyArtifactsFlyoutProps {
+  policyItem: ImmutableObject<PolicyData>;
+  apiClient: ExceptionsListApiClient;
+  searcheableFields: string[];


nitpick: typo

Suggested change

searcheableFields: string[];

searchableFields: string[];

ashokaditya · 2022-03-09T13:47:55Z

...ty_solution/public/management/pages/policy/view/artifacts/flyout/policy_artifacts_flyout.tsx

+      isLoading: isLoadingArtifacts,
+      isRefetching: isRefetchingArtifacts,


ashokaditya · 2022-03-09T13:49:30Z

...ugins/security_solution/public/management/pages/policy/view/artifacts/flyout/translations.ts

+      values: { policyName },
+    }),
+  flyoutSearchPlaceholder: i18n.translate(
+    'xpack.securitySolution.endpoint.policy.artifacts.layout.searh.label',


Suggested change

'xpack.securitySolution.endpoint.policy.artifacts.layout.searh.label',

'xpack.securitySolution.endpoint.policy.artifacts.layout.search.label',

ashokaditya · 2022-03-09T15:13:36Z

...ins/security_solution/public/management/pages/policy/view/tabs/event_filters_translations.ts

+      values: { policyName },
+    }),
+  flyoutSearchPlaceholder: i18n.translate(
+    'xpack.securitySolution.endpoint.policy.eventFilters.layout.searh.label',


Suggested change

'xpack.securitySolution.endpoint.policy.eventFilters.layout.searh.label',

'xpack.securitySolution.endpoint.policy.eventFilters.layout.search.label',

ashokaditya · 2022-03-09T15:22:16Z

x-pack/plugins/security_solution/public/management/hooks/artifacts/use_list_artifact.tsx

  },
-  customQueryOptions: UseQueryOptions<FoundExceptionListItemSchema, HttpFetchError>
+  searcheableFields: MaybeImmutable<string[]> = DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS,


nitpick: typo

Suggested change

searcheableFields: MaybeImmutable<string[]> = DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS,

searchableFields: MaybeImmutable<string[]> = DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS,

dasansol92 · 2022-03-09T15:43:40Z

@ashokaditya Thanks for all the suggestions and typo's. Everything is in this commit: c5e2545

dasansol92 · 2022-03-09T16:05:32Z

@elasticmachine merge upstream

…component_to_be_used_for_all_of_our_artifacts-3173

…o_be_used_for_all_of_our_artifacts-3173' of github.com:dasansol92/kibana into feat/olm-create_generic_policy_tab_artifact_component_to_be_used_for_all_of_our_artifacts-3173

kibana-ci · 2022-03-10T10:07:12Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.7MB	4.7MB	-36.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	245.1KB	245.1KB	+29.0B

Unknown metric groups

async chunk count

id	before	after	diff
`securitySolution`	21	22	+1

ESLint disabled line counts

id	before	after	diff
`securitySolution`	447	440	-7

Total ESLint disabled count

id	before	after	diff
`securitySolution`	514	507	-7

History

💔 Build #28873 failed 999a339
💔 Build #28857 failed c5e2545
💔 Build #28736 failed cbc8ef9
💔 Build #28718 failed d99ba65
💚 Build #28044 succeeded 8ff085a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…move-pdf-generation-to-screenshotting * 'main' of github.com:elastic/kibana: (62 commits) [Lens] Drop partial buckets option (elastic#127153) chore(NA): remove unused translation xpack.ml.management.jobsSpacesList.objectNoun from fr-FR (elastic#127457) Add data to user details page (elastic#127019) [Fleet] Make upload and registry package info consistent (elastic#126915) [Reporting] Capture browser errors (elastic#127135) Initial readme commit with some stub articles (elastic#127420) skip flaky suite (elastic#121482) skip flaky suite (elastic#127416) Tests to ensure Kibana is handling multi-space import of saved objects correctly (elastic#127229) [Aggs] remove toAngularJson (elastic#127267) [i18n] Integrate 8.2.0 Translations (elastic#127309) [Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts (elastic#126685) [Kibana React] Fix Page Template `solutionNav` propagation (elastic#127140) [Cases] Export getRelatedCases API from cases client (elastic#127065) [Cloud Posture]add support for sorting benchmark page (elastic#126983) [User experience] Fix filters for the app (elastic#127295) [Fleet] Fix timeserie dimension mapping (elastic#127328) [data view mgmt] fix data view name wrap (elastic#127319) [kbn/optimizer] extract string diffing logic (elastic#127394) [ResponseOps] Add pagination and sorting to the alerts search strategy (elastic#126813) ... # Conflicts: # x-pack/plugins/screenshotting/common/errors.ts # x-pack/plugins/screenshotting/common/index.ts # x-pack/plugins/screenshotting/server/screenshots/observable.ts

kibanamachine · 2022-03-14T10:56:20Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126685 or prevent reminders by adding the backport:skip label.

kibanamachine · 2022-03-15T11:06:18Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126685 or prevent reminders by adding the backport:skip label.

dasansol92 added 2 commits March 1, 2022 17:54

Initial commit adding a generic component for policy artifact tabs

5f8acfd

Adds labels and translations. Also fixes loading state using isRefetc…

d8ef30d

…hing

dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.0 labels Mar 2, 2022

dasansol92 added 5 commits March 2, 2022 17:16

Fix checks and wrong count update when removing/adding items

fc1c6f2

Fixes translations and adds extra privileges checks

399e009

Merge branch 'main' into feat/olm-create_generic_policy_tab_artifact_…

474b3e8

…component_to_be_used_for_all_of_our_artifacts-3173

Use hook to retrieve url params instead of redux

f565083

Fixes wrong loading state in flyout

bfb832c

paul-tavares reviewed Mar 3, 2022

View reviewed changes

dasansol92 added 12 commits March 4, 2022 11:47

Extracts conditional artifact logic from generic components and adds …

1e228a6

…an artifact_layout unit test

Include new changes in policy tabs component

39ee3b8

Adds policy artifact flyout unit test

fced0a2

Adds policy artifacts list unit test

9f1fe11

Adds policy artifacts delete modal unit test

a130ea1

Adds external privileges checks on unit tests

b575edd

Uses FormattedMessage to include EuiLink inside the translation

5320a7a

Uses FormattedMessage

c69b0e3

Generate new ExceptionsListApiClient instance when http changes

4211893

Removes existing policy tab artifacts code in favor of generic component

c4b01a7

Merge branch 'main' into feat/olm-create_generic_policy_tab_artifact_…

0fc7869

…component_to_be_used_for_all_of_our_artifacts-3173

Update translation files

8ff085a

dasansol92 marked this pull request as ready for review March 7, 2022 15:58

dasansol92 requested a review from a team as a code owner March 7, 2022 15:58

dasansol92 requested review from pzl and parkiino March 7, 2022 15:58

dasansol92 requested review from paul-tavares and ashokaditya March 8, 2022 13:49

paul-tavares reviewed Mar 8, 2022

View reviewed changes

parkiino reviewed Mar 9, 2022

View reviewed changes

dasansol92 added 2 commits March 9, 2022 09:38

Merge branch 'main' into feat/olm-create_generic_policy_tab_artifact_…

1a5bb51

…component_to_be_used_for_all_of_our_artifacts-3173

Include pr suggestions

d99ba65

dasansol92 requested review from parkiino and paul-tavares March 9, 2022 10:37

dasansol92 added 3 commits March 9, 2022 12:19

Uses useUrlPagination hook for pagination

92ee2c3

Fix checks

cbc8ef9

Fixes uni test

ed6c258

paul-tavares approved these changes Mar 9, 2022

View reviewed changes

Reorder use_list_artifact hook params and move custom getInstance fun…

63f8f9a

…ctions inside a useCallback

ashokaditya approved these changes Mar 9, 2022

View reviewed changes

Fix typos and added pr feedback

c5e2545

Merge branch 'main' into feat/olm-create_generic_policy_tab_artifact_…

999a339

…component_to_be_used_for_all_of_our_artifacts-3173

ashokaditya approved these changes Mar 9, 2022

View reviewed changes

dasansol92 added 2 commits March 10, 2022 09:34

Fix typo in searchableFields props and vars

f1bd38f

Merge branch 'feat/olm-create_generic_policy_tab_artifact_component_t…

ef61835

…o_be_used_for_all_of_our_artifacts-3173' of github.com:dasansol92/kibana into feat/olm-create_generic_policy_tab_artifact_component_to_be_used_for_all_of_our_artifacts-3173

dasansol92 merged commit 776fe46 into elastic:main Mar 10, 2022

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 14, 2022

dasansol92 added the backport:skip This commit does not require backporting label Mar 15, 2022

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2022

		getExceptionsListApiClient={() => TrustedAppsApiClient.getInstance(http)}
		searcheableFields={[...TRUSTED_APPS_SEARCHABLE_FIELDS]}

	const artifactssToUpdate: ExceptionListItemSchema[] = [];
	const artifactsToUpdate: ExceptionListItemSchema[] = [];

		isLoading: isLoadingArtifacts,
		isRefetching: isRefetchingArtifacts,

	'xpack.securitySolution.endpoint.policy.artifacts.layout.searh.label',
	'xpack.securitySolution.endpoint.policy.artifacts.layout.search.label',

	searcheableFields: MaybeImmutable<string[]> = DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS,
	searchableFields: MaybeImmutable<string[]> = DEFAULT_EXCEPTION_LIST_ITEM_SEARCHABLE_FIELDS,

[Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts #126685

[Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts #126685

Conversation

dasansol92 commented Mar 2, 2022 • edited Loading

Summary

For maintainers

paul-tavares left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashokaditya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dasansol92 commented Mar 9, 2022

dasansol92 commented Mar 9, 2022

kibana-ci commented Mar 10, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Mar 14, 2022

kibanamachine commented Mar 15, 2022

dasansol92 commented Mar 2, 2022 •

edited

Loading