-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime monitor management] Make index template installation retry #125537
Conversation
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Working as expected.
Tested by forcing a network issue for package registry on startup. Package was not installed.
I then resolved the error, and during the next task I saw the log saying that the package was installed successfully.
Pinging @elastic/uptime (Team:uptime) |
Tested and it also prevents Kibana from crashing on the following error: ResponseError: search_phase_execution_exception: [illegal_argument_exception] Reason: no mapping found for `config_id` in order to collapse on; ... |
…pdf-generation-in-worker-thread * 'main' of github.com:elastic/kibana: (40 commits) Service overview e2e test (elastic#125359) [Graph] Make graph edges easier to click (elastic#124053) [Reporting] Add additional PNG and PDF metrics (elastic#125450) [APM] Lint rule for explicit return types (elastic#124771) [SecuritySolution] Enrich threshold data from correct fields (elastic#125376) [Uptime monitor management] Make index template installation retry (elastic#125537) [Console] Support suggesting index templates v2 (elastic#124655) [Logs UI] Support switching between log source modes (elastic#124929) SavedObjects management: change index patterns labels to data views (elastic#125356) [ci-stats] add Client class for accessing test group stats (elastic#125164) [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283) [Fleet] Add retries when starting docker registry in integration tests (elastic#125530) Update osquery.asciidoc to address doc issue (elastic#125425) synthetics e2e - use custom location when defined (elastic#125560) [ci] Retry failed steps in on-merge pipeline (elastic#125550) [babel] Bump babel packages (elastic#125446) [DOCS] Updates Upgrade Assistant API status (elastic#125410) [DOCS] Minor tweaks to upgrade docs (elastic#125538) [Uptime] handle null duration on ping list (elastic#125438) [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts # x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts # x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Will try installing templates again in service, also prevent from making query if the installation is not done yet.