[APM] Lint rule for explicit return types #124771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Feb 9, 2022
💚 Build SucceededMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Feb 15, 2022
(cherry picked from commit 0202164)
dgieselaar
added
backport:skip
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 15, 2022
…pdf-generation-in-worker-thread * 'main' of github.com:elastic/kibana: (40 commits) Service overview e2e test (elastic#125359) [Graph] Make graph edges easier to click (elastic#124053) [Reporting] Add additional PNG and PDF metrics (elastic#125450) [APM] Lint rule for explicit return types (elastic#124771) [SecuritySolution] Enrich threshold data from correct fields (elastic#125376) [Uptime monitor management] Make index template installation retry (elastic#125537) [Console] Support suggesting index templates v2 (elastic#124655) [Logs UI] Support switching between log source modes (elastic#124929) SavedObjects management: change index patterns labels to data views (elastic#125356) [ci-stats] add Client class for accessing test group stats (elastic#125164) [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283) [Fleet] Add retries when starting docker registry in integration tests (elastic#125530) Update osquery.asciidoc to address doc issue (elastic#125425) synthetics e2e - use custom location when defined (elastic#125560) [ci] Retry failed steps in on-merge pipeline (elastic#125550) [babel] Bump babel packages (elastic#125446) [DOCS] Updates Upgrade Assistant API status (elastic#125410) [DOCS] Minor tweaks to upgrade docs (elastic#125538) [Uptime] handle null duration on ping list (elastic#125438) [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts # x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts # x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts
dgieselaar
added a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a lint rule that requires explicit function return types in all route.ts files (for performance reasons, as mentioned in #123266).