Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Add additional PNG and PDF metrics #125450

Merged
merged 7 commits into from
Feb 15, 2022
Merged

[Reporting] Add additional PNG and PDF metrics #125450

merged 7 commits into from
Feb 15, 2022

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Feb 11, 2022 •
edited
Loading

Summary

Resolves #121468.

Checklist

For maintainers

@dokmic dokmic added review (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx v8.2.0 labels Feb 11, 2022
@dokmic dokmic marked this pull request as ready for review February 14, 2022 09:24
@dokmic dokmic requested review from a team as code owners February 14, 2022 09:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@dokmic
Copy link
Contributor Author

dokmic commented Feb 14, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #15 / machine learning model management trained models for ML user with read-only access renders expanded row content correctly for model with pipelines

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 59.4KB 60.5KB +1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 38.7KB 38.6KB -63.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
reporting 7 8 +1

Total ESLint disabled count

id before after diff
reporting 8 9 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan reviewed Feb 14, 2022
View reviewed changes
x-pack/plugins/reporting/common/types/index.ts
max_size_reached?: boolean;
warnings?: string[];
metrics?: TaskRunMetrics;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tsullivan
tsullivan reviewed Feb 14, 2022
View reviewed changes
x-pack/plugins/reporting/common/types/index.ts
@@ -5,6 +5,8 @@
* 2.0.
*/

// eslint-disable-next-line @kbn/eslint/no-restricted-paths
import type { ScreenshotResult } from '../../../screenshotting/server';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dokmic we should file an issue (low priority) to move this interface to common under the screenshots plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be problematic since it has Buffer in it. That's Node.js's data structure.

tsullivan
tsullivan approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokmic dokmic merged commit 556b629 into elastic:main Feb 15, 2022
@dokmic dokmic deleted the feature/121468 branch February 15, 2022 09:38
jloleysens
jloleysens approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dokmic !

This is so cool:

Screenshot 2022-02-15 at 11 55 35

I tested locally and confirmed that old reports and new reports behave as expected.

One thought I had, nothing to action, these CPU/RAM numbers are taken from the browser, but there is potentially more work happening for PDFs. I thought maybe a disclaimer around what exactly they represent or that they are "the image generation stats" of reporting might be useful. But then I couldn't think of a good way to frame so I think it's better to leave as is.

It would be nice to add a test for the addition of metrics to the flyout in: x-pack/plugins/reporting/public/management/report_listing.test.ts, but happy if we do this in a follow up PR too.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 15, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into screenshotting/…
11c9878 
…pdf-generation-in-worker-thread

* 'main' of github.com:elastic/kibana: (40 commits)
  Service overview e2e test (elastic#125359)
  [Graph] Make graph edges easier to click (elastic#124053)
  [Reporting] Add additional PNG and PDF metrics  (elastic#125450)
  [APM] Lint rule for explicit return types (elastic#124771)
  [SecuritySolution] Enrich threshold data from correct fields (elastic#125376)
  [Uptime monitor management] Make index template installation retry (elastic#125537)
  [Console] Support suggesting index templates v2 (elastic#124655)
  [Logs UI] Support switching between log source modes (elastic#124929)
  SavedObjects management: change index patterns labels to data views (elastic#125356)
  [ci-stats] add Client class for accessing test group stats (elastic#125164)
  [ML] Use Discover locator in Data Visualizer instead of URL Generator (elastic#124283)
  [Fleet] Add retries when starting docker registry in integration tests (elastic#125530)
  Update osquery.asciidoc to address doc issue (elastic#125425)
  synthetics e2e - use custom location when defined (elastic#125560)
  [ci] Retry failed steps in on-merge pipeline (elastic#125550)
  [babel] Bump babel packages (elastic#125446)
  [DOCS] Updates Upgrade Assistant API status (elastic#125410)
  [DOCS] Minor tweaks to upgrade docs (elastic#125538)
  [Uptime] handle null duration on ping list (elastic#125438)
  [TSVB][Lens] Navigate to Lens with your current configuration (elastic#114794)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/pdf/pdfmaker.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf/lib/generate_pdf.ts
#	x-pack/plugins/reporting/server/export_types/printable_pdf_v2/lib/generate_pdf.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 17, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125450 or prevent reminders by adding the backport:skip label.

@dokmic dokmic added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 17, 2022
@tsullivan tsullivan mentioned this pull request Feb 24, 2022
Merged
@tsullivan tsullivan mentioned this pull request Jun 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] Add more helpful job metrics to report output
6 participants
@dokmic @elasticmachine @kibana-ci @kibanamachine @tsullivan @jloleysens