Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storybook][eui] Add EUIThemeProvider to kbn-storybook #122094

Merged
merged 1 commit into from
Dec 28, 2021
Merged

[storybook][eui] Add EUIThemeProvider to kbn-storybook #122094

merged 1 commit into from
Dec 28, 2021

Conversation

clintandrewhall
Copy link
Contributor

Summary

This PR is a clean change derived from #121901

Fixes #121557
Contributes to #121654
Closes #121901

This PR adds the EuiThemeProvider as a decorator to kbn-storybook preset. This ensures all Kibana Storybooks will inherit the EUI theme without having to add the decorator manually to every plugin.

Without this provider, all Storybooks appear to be broken due to lack of EUI styles.

@clintandrewhall clintandrewhall added review loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. EUI Feature:Storybook v8.1.0 v8.2.0 labels Dec 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@clintandrewhall clintandrewhall enabled auto-merge (squash) December 28, 2021 19:32
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

chandlerprall
chandlerprall approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; also compared these with the initial proposed changes from #121901

@clintandrewhall clintandrewhall merged commit 8890384 into elastic:main Dec 28, 2021
@clintandrewhall clintandrewhall deleted the storybook/eui-theme-context branch December 29, 2021 17:47
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 30, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

8 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@clintandrewhall clintandrewhall mentioned this pull request Jan 13, 2022
Closed
@clintandrewhall
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jan 13, 2022
@clintandrewhall
[storybook][eui] Add EUIThemeProvider to kbn-storybook (elastic#122094)
e5b6f18 
(cherry picked from commit 8890384)
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122094 or prevent reminders by adding the backport:skip label.

@clintandrewhall clintandrewhall added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.2.0 labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

@smith smith Awaiting requested review from smith

@spalger spalger Awaiting requested review from spalger

@thompsongl thompsongl Awaiting requested review from thompsongl

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Feature:Storybook impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clintandrewhall @elasticmachine @kibana-ci @kibanamachine @chandlerprall