Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Observability] Fix stories #121557

Merged
merged 7 commits into from
Dec 30, 2021
Merged

[Unified Observability] Fix stories #121557

merged 7 commits into from
Dec 30, 2021

Conversation

estermv
Copy link
Contributor

@estermv estermv commented Dec 17, 2021 •
edited
Loading

Summary

While adding stories for a new component I saw that there some stories from the Observability plugin were failing. This PR fixes them.

@estermv estermv added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:Unified observability labels Dec 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@estermv
Copy link
Contributor Author

estermv commented Dec 20, 2021

@elasticmachine merge upstream

@estermv estermv requested a review from a team December 27, 2021 12:17
@clintandrewhall clintandrewhall mentioned this pull request Dec 28, 2021
Merged
@estermv estermv reopened this Dec 29, 2021
@estermv
Copy link
Contributor Author

estermv commented Dec 29, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afgomez
afgomez approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now! Thank you for looking into it

@estermv estermv merged commit cf81ece into elastic:main Dec 30, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgomez afgomez afgomez approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estermv @elasticmachine @kibana-ci @afgomez @kibanamachine