Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn-storybook] Add decorator for EuiProvider #121901

Closed
wants to merge 3 commits into from
Closed

[kbn-storybook] Add decorator for EuiProvider #121901

wants to merge 3 commits into from

Conversation

thompsongl
Copy link
Contributor

Summary

Adds a global decorator for EuiProvider to ensure reset and global styles. Can expand consumption to all .storybook/ instances if the approach looks correct.

@thompsongl thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI v8.1.0 labels Dec 22, 2021
@thompsongl
Copy link
Contributor Author

5b219b9 moves the decorator to kbn-storybook but storybook fails to compile. My guess is that we need to access EUI via the kbn-shared-deps bundle, but @mistic may know better.

This was referenced Dec 27, 2021
Merged
Merged
@clintandrewhall clintandrewhall mentioned this pull request Dec 28, 2021
Merged
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintandrewhall clintandrewhall clintandrewhall left review comments

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibana-ci @clintandrewhall