Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting][UI] Fixes missing EUI theme in context #121796

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

claudiopro
Copy link
Contributor

@claudiopro claudiopro commented Dec 21, 2021

Summary

This PR addresses a missing EUI theme in the context of the Triggers Actions UI component tree, resulting in an error when rendering the chart preview for some rule types.

Fixes #121793.

Checklist

@claudiopro claudiopro requested a review from a team as a code owner December 21, 2021 16:11
@claudiopro
Copy link
Contributor Author

Regression from #121415.

@claudiopro claudiopro added auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.1.0 Theme: rac label obsolete labels Dec 21, 2021
@claudiopro
Copy link
Contributor Author

See #121415 (comment) for an explanation.

@claudiopro
Copy link
Contributor Author

This is not an issue in v8.0, as the change #121415 was only merged in main.

@claudiopro claudiopro requested a review from a team December 21, 2021 16:27
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LGTM

@claudiopro claudiopro enabled auto-merge (squash) December 21, 2021 16:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 330 332 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 780.3KB 780.9KB +578.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 53.8KB 53.9KB +49.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@claudiopro claudiopro merged commit dae791b into elastic:main Dec 21, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 21, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 121796

@claudiopro claudiopro removed the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 21, 2021
@claudiopro claudiopro deleted the issue_121793 branch December 21, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAC][APM] Chart fails to render with error when creating a new rule
4 participants