-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting][UI] Using KibanaThemeProvider #121415
Conversation
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not quite, unfortunately! The two context providers are different, despite they have the same name.
while kibana/src/plugins/kibana_react/common/eui_styled_components.tsx Lines 20 to 36 in 4681a80
cc @pgayvallet FYI this may be misleading |
Well well... That's the first time I'm hearing about this Thanks for the heads up |
Resolves #118880
Summary
Wrapping
triggers_actions_ui
app render withKibanaThemeProvider
.KibanaThemeProvider
wrapsEuiThemeProvider
so removed usage ofEuiThemeProvider