Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Adapt all existing applications to use the new KibanaThemeProvider #118880

Closed
mikecote opened this issue Nov 17, 2021 · 1 comment · Fixed by #121415
Closed

[Alerting] Adapt all existing applications to use the new KibanaThemeProvider #118880

mikecote opened this issue Nov 17, 2021 · 1 comment · Fixed by #121415
Assignees
Labels
chore estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

See #118866

For the css-in-js initiative, the EUI team recently added a new theme context provider: EuiThemeProvider (see #108972 and elastic/eui#4511).

To have Kibana be ready to use the features related to this theme provider, we need all react applications to wrap their root component / react trees with it. Ideally, this would have been done exclusively at core's level, however, due to the agnostic nature of core's apps, and the fact that applications are effectively distinct react trees (e.g calling ReactDOM.render during their mount), we will need all application owners to adapt their application mounting points.

Also, applications are not the only parts of Kibana rendering react trees. For example, all usage of kibana_react's toMountPoint also need to be adapted, as, for example, when calling core.overlays.openFlyout(mountPoint). Management sections needs to be adapted too.

EUI is planning on leveraging the theme provider to carry the reset styles in their next phase, for 8.1, so this has to be done for the 8.1 FF

@mikecote mikecote added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Nov 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris added the chore label Nov 17, 2021
@mikecote mikecote added the estimate:medium Medium Estimated Level of Effort label Dec 13, 2021
@ymao1 ymao1 self-assigned this Dec 16, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants