[Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing #119441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
bug
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @sabarasaba |
sebelga
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Tested locally and works as expected! Great job @sabarasaba 👍
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Nov 24, 2021
…ng (elastic#119441) * Add index_mapper_dynamic to removeList * commit using @elastic.co
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Nov 24, 2021
…ng (elastic#119441) * Add index_mapper_dynamic to removeList * commit using @elastic.co
sabarasaba
added a commit
that referenced
this pull request
Nov 24, 2021
…move duped copy from header (#119570) * [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441) * Add index_mapper_dynamic to removeList * commit using @elastic.co * [Upgrade Assistant] Remove duped copy from header (#119476) * Remove duped copy from header * commit using @elastic.co Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…emove duped copy from header (elastic#119569) * [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (elastic#119441) * [Upgrade Assistant] Remove duped copy from header (elastic#119476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As surfaced by #116212, when updating from 5.5 to 6.20 to 7.16 and attempting to reindex
.reindexed-v6-kibana-6users get an error sayingSetting index.mapper.dynamic was removed after version 6.0.0. This is a manual deprecation that needs to be solved before running the reindex process. Turns out that within the UA reindexing code there's a list of blacklisted settings that get removed before the reindexing runs and this particular setting, that was removed with elasticsearch#51718, is not there.How to test
yarn es snapshot -E path.data=/path/to/5.5-data-snapshot. This contains indices from 5.5 that where migrated to 6.8 and then to 7.16.Stack Management->Upgrade Assistant->ES deprecation issues.reindexed-v6-kibana-6there are two critical deprecations:Index created before 7.0andSetting [index.mapper.dynamic] is deprecatedIndex created before 7.0deprecation and verify that it can be successfully re-indexedRefreshCTA from theES deprecation issuespage, theSetting [index.mapper.dynamic] is deprecateddeprecation is gone.If after following the steps you don't see any deprecations for es in upgrade assistant, try unzipping the folder in the
kibana/.esfolder and starting up es with:yarn es snapshot -E path.data=../5.5-data-snapshotScreenshots
before/after
// With error
// Solved deprecation
