Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Remove duped copy from header #119476

Merged

Conversation

sabarasaba
Copy link
Member

The ES deprecations page has a duped portion of the copy, this PR addresses that.

Screenshots

before/after

// Before
143031443-c105c7aa-c6e4-4c02-8048-38e5cd2da33b

// After
Screenshot 2021-11-23 at 15 02 11

@sabarasaba sabarasaba added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant backport:skip This commit does not require backporting v7.16.1 labels Nov 23, 2021
@sabarasaba sabarasaba requested a review from sebelga November 23, 2021 14:05
@sabarasaba sabarasaba self-assigned this Nov 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 138.7KB 138.6KB -89.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit a35f543 into elastic:7.16 Nov 24, 2021
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Nov 24, 2021
* Remove duped copy from header

* commit using @elastic.co

Co-authored-by: Kibana Machine <[email protected]>
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Nov 24, 2021
* Remove duped copy from header

* commit using @elastic.co

Co-authored-by: Kibana Machine <[email protected]>
sabarasaba added a commit that referenced this pull request Nov 24, 2021
…emove duped copy from header (#119569)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441)
* [Upgrade Assistant] Remove duped copy from header (#119476)
sabarasaba added a commit that referenced this pull request Nov 24, 2021
…move duped copy from header (#119570)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441)

* Add index_mapper_dynamic to removeList

* commit using @elastic.co

* [Upgrade Assistant] Remove duped copy from header (#119476)

* Remove duped copy from header

* commit using @elastic.co

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
…emove duped copy from header (#119569)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441)
* [Upgrade Assistant] Remove duped copy from header (#119476)
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…emove duped copy from header (elastic#119569)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (elastic#119441)
* [Upgrade Assistant] Remove duped copy from header (elastic#119476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants