Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing #119008

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Nov 18, 2021

Summary

As surfaced by #116212, when updating from 5.5 to 6.20 to 7.16 and attempting to reindex .reindexed-v6-kibana-6 users get an error saying Setting index.mapper.dynamic was removed after version 6.0.0. This is a manual deprecation that needs to be solved before running the reindex process. Turns out that within the UA reindexing code there's a list of blacklisted settings that get removed before the reindexing runs and this particular setting, that was removed with elasticsearch#51718, is not there.

How to test

  1. Unzip 5.5-data-snapshot.zip and start up ES as follows: yarn es snapshot -E path.data=/path/to/5.5-data-snapshot. This contains indices from 5.5 that where migrated to 6.8 and then to 7.16.
  2. Navigate to Stack Management -> Upgrade Assistant -> ES deprecation issues
  3. Verify that for .reindexed-v6-kibana-6 there are two critical deprecations: Index created before 7.0 and Setting [index.mapper.dynamic] is deprecated
  4. Open the Index created before 7.0 deprecation and verify that it can be successfully re-indexed
  5. Verify after clicking the Refresh CTA from the ES deprecation issues page, the Setting [index.mapper.dynamic] is deprecated deprecation is gone.

If after following the steps you don't see any deprecations for es in upgrade assistant, try unzipping the folder in the kibana/.es folder and starting up es with: yarn es snapshot -E path.data=../5.5-data-snapshot

Screenshots

before/after

// With error
138763612-18f03d01-5058-44e5-a160-80438561f794

// Solved deprecation
141445459-42814480-3a15-4e98-a3eb-6b2d0f86446c

@sabarasaba sabarasaba self-assigned this Nov 18, 2021
@sabarasaba sabarasaba added Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.0 v8.0.0 v8.1.0 v7.16.1 bug Fixes for quality problems that affect the customer experience and removed v8.1.0 v7.16.1 labels Nov 18, 2021
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba requested a review from sebelga November 18, 2021 12:41
@sabarasaba sabarasaba marked this pull request as ready for review November 18, 2021 12:41
@sabarasaba sabarasaba requested a review from a team as a code owner November 18, 2021 12:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sabarasaba sabarasaba added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 19, 2021
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba changed the base branch from main to 7.16 November 23, 2021 10:33
@sabarasaba sabarasaba changed the base branch from 7.16 to main November 23, 2021 10:33
@sabarasaba sabarasaba closed this Nov 23, 2021
@sabarasaba
Copy link
Member Author

Closed in favour of #119441 that points to 7.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.1 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants