[APM] Auto attachment for java agent beta in APM integration settings #119131

ogupte · 2021-11-19T07:07:28Z

RuntimeAttachment component can be tested in storybook: yarn storybook apm

Remaining Tasks

[@cauemarcondes]Description text "Learn more in the docs." should link to https://www.elastic.co/guide/en/apm/agent/java/current/setup-attach-cli.html
[@cauemarcondes] Add i18n support for all text
[@cauemarcondes]Update 'user' type option description text to "A username that is matched against the operating system user that runs the JVM."
[@cauemarcondes] Add select for the java agent version to be attached to the service, use input var java_attacher_agent_version:
- Either the list will be auto-determined using the GitHub releases API: https://api.github.com/repos/elastic/apm-agent-java/releases or https://api.github.com/repos/elastic/apm-agent-java/tags
- Or Kibana ships with a static list of known versions. As there may be new Java agent releases that Kibana doesn't know about yet, users can enter a plain-text value for the version.

This requires the pre-release version of the APM package which exist in the staging and snapshot package-registry deployments (https://epr-snapshot.elastic.co/package/apm/8.0.0-dev4/), to point to snapshot package registry in kibana, set:

// kibana.dev.yml

xpack.fleet.registryUrl: https://epr-snapshot.elastic.co

- adds workaround for extra 'elasticsearch' field on integration policy updates - updates migration package version from 7.16.0 to 8.0.0-dev4

ogupte · 2021-12-03T22:04:49Z

x-pack/plugins/apm/common/fleet.ts

@@ -8,7 +8,7 @@ import semverParse from 'semver/functions/parse';

 export const POLICY_ELASTIC_AGENT_ON_CLOUD = 'policy-elastic-agent-on-cloud';

-export const SUPPORTED_APM_PACKAGE_VERSION = '7.16.0';
+export const SUPPORTED_APM_PACKAGE_VERSION = '8.0.0-dev4'; // TODO update to just '8.0.0' once published


once 8.0.0 is published in staging or snapshot deployments of the package-registry, this needs to be updated.

elasticmachine · 2021-12-03T22:04:53Z

Pinging @elastic/fleet (Team:Fleet)

…-attach-java-agent

kibana-ci · 2021-12-07T21:45:12Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1174	1215	+41

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	3.0MB	⚠️ +209.0KB
`fleet`	643.4KB	643.4KB	+24.0B
total			+209.1KB

History

💚 Build #11834 succeeded 29f7359
💚 Build #11775 succeeded f57c627
💛 Build #11534 was flaky a7b74cd
💔 Build #11160 failed 7055d3c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-12-07T21:45:35Z

The following labels were identified as gaps in your version labels and will be added automatically:

v8.1.0

If any of these should not be on your pull request, please manually remove them.

…elastic#119131) * wip * wip * wip * wip * wip * wip * wip * wip * adds initial discovery rule for `include-vmargs elastic.apm.attach=true` * adds support for type descriptions * adding java_attacher_agent_version field * fixing some stuff * adding link to doc * adding internationalization * updating user description * fixing default version * setting to null when disabled * - fixes encoding and decoding discovery rules yaml - adds workaround for extra 'elasticsearch' field on integration policy updates - updates migration package version from 7.16.0 to 8.0.0-dev4 * addressing pr comments * fixing ci * fixing elements not visible while dragging * addressing PR changes * beta * adding tooltip back * addressing pr comments Co-authored-by: cauemarcondes <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-12-07T21:48:46Z

💚 Backport successful

Status	Branch	Result
✅	8.0

This backport PR will be merged automatically after passing CI.

…#119131) (#120691) * wip * wip * wip * wip * wip * wip * wip * wip * adds initial discovery rule for `include-vmargs elastic.apm.attach=true` * adds support for type descriptions * adding java_attacher_agent_version field * fixing some stuff * adding link to doc * adding internationalization * updating user description * fixing default version * setting to null when disabled * - fixes encoding and decoding discovery rules yaml - adds workaround for extra 'elasticsearch' field on integration policy updates - updates migration package version from 7.16.0 to 8.0.0-dev4 * addressing pr comments * fixing ci * fixing elements not visible while dragging * addressing PR changes * beta * adding tooltip back * addressing pr comments Co-authored-by: cauemarcondes <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Oliver Gupte <[email protected]> Co-authored-by: cauemarcondes <[email protected]>

Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first. Originally fixed in elastic#119131. Co-authored-by: ogupte <[email protected]>

Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first. Originally fixed in #119131. Co-authored-by: ogupte <[email protected]> Co-authored-by: ogupte <[email protected]>

cauemarcondes · 2021-12-20T19:06:58Z

tests okay

…elastic#119131) * wip * wip * wip * wip * wip * wip * wip * wip * adds initial discovery rule for `include-vmargs elastic.apm.attach=true` * adds support for type descriptions * adding java_attacher_agent_version field * fixing some stuff * adding link to doc * adding internationalization * updating user description * fixing default version * setting to null when disabled * - fixes encoding and decoding discovery rules yaml - adds workaround for extra 'elasticsearch' field on integration policy updates - updates migration package version from 7.16.0 to 8.0.0-dev4 * addressing pr comments * fixing ci * fixing elements not visible while dragging * addressing PR changes * beta * adding tooltip back * addressing pr comments Co-authored-by: cauemarcondes <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first. Originally fixed in elastic#119131. Co-authored-by: ogupte <[email protected]> Co-authored-by: ogupte <[email protected]>

Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first. Originally fixed in #119131. Co-authored-by: ogupte <[email protected]> Co-authored-by: ogupte <[email protected]> Co-authored-by: Mark Hopkin <[email protected]>

ogupte added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes skip-ci labels Nov 19, 2021

ogupte added 10 commits December 2, 2021 01:28

wip

a2621da

wip

1fe9086

wip

43eddab

wip

858c670

wip

4ec12b1

wip

24f8b9b

wip

8556e41

wip

c445779

adds initial discovery rule for include-vmargs elastic.apm.attach=true

105af2f

adds support for type descriptions

4497c91

ogupte force-pushed the apm-108513-auto-attach-java-agent branch from bce908a to 4497c91 Compare December 2, 2021 06:29

cauemarcondes and others added 8 commits December 2, 2021 15:17

adding java_attacher_agent_version field

42adcaf

fixing some stuff

9315aa1

adding link to doc

8853433

adding internationalization

e40d6e9

updating user description

c90c3d0

fixing default version

21d298a

setting to null when disabled

da4b613

- fixes encoding and decoding discovery rules yaml

569ad95

- adds workaround for extra 'elasticsearch' field on integration policy updates - updates migration package version from 7.16.0 to 8.0.0-dev4

ogupte removed the skip-ci label Dec 3, 2021

ogupte marked this pull request as ready for review December 3, 2021 22:03

ogupte requested review from a team as code owners December 3, 2021 22:03

ogupte commented Dec 3, 2021

View reviewed changes

botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 3, 2021

cauemarcondes added 2 commits December 7, 2021 14:48

Merge branch 'main' of github.com:elastic/kibana into apm-108513-auto…

524dcd7

…-attach-java-agent

addressing pr comments

5c93cbf

cauemarcondes added auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 7, 2021

cauemarcondes requested a review from smith December 7, 2021 20:33

cauemarcondes enabled auto-merge (squash) December 7, 2021 20:33

smith approved these changes Dec 7, 2021

View reviewed changes

cauemarcondes merged commit 2a937d0 into elastic:main Dec 7, 2021

kibanamachine added the v8.1.0 label Dec 7, 2021

kibanamachine mentioned this pull request Dec 7, 2021

[8.0] [APM] Auto attachment for java agent beta in APM integration settings (#119131) #120691

Merged

joshdover mentioned this pull request Dec 16, 2021

Can't upgrade APM integration to version 7.16.1 on ESS #121238

Closed

hop-dev mentioned this pull request Dec 16, 2021

[Fleet] Omit elasticsearch field for policy update API (partial backport of #119131) #121412

Merged

cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Dec 20, 2021

eyalkoren mentioned this pull request Dec 21, 2021

Testing Agent attach with Fleet elastic/apm-agent-java#2196

Closed

sorenlouv added the apm:test-plan-8.0.0 label Dec 21, 2021

ogupte mentioned this pull request Mar 15, 2022

[APM] Enables Java runtime attacher UI in Fleet integration agents tab #127790

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Auto attachment for java agent beta in APM integration settings #119131

[APM] Auto attachment for java agent beta in APM integration settings #119131

ogupte commented Nov 19, 2021 •

edited

Loading

ogupte Dec 3, 2021

elasticmachine commented Dec 3, 2021

kibana-ci commented Dec 7, 2021

kibanamachine commented Dec 7, 2021

kibanamachine commented Dec 7, 2021

cauemarcondes commented Dec 20, 2021

[APM] Auto attachment for java agent beta in APM integration settings #119131

[APM] Auto attachment for java agent beta in APM integration settings #119131

Conversation

ogupte commented Nov 19, 2021 • edited Loading

Remaining Tasks

ogupte Dec 3, 2021

Choose a reason for hiding this comment

elasticmachine commented Dec 3, 2021

kibana-ci commented Dec 7, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Dec 7, 2021

kibanamachine commented Dec 7, 2021

💚 Backport successful

cauemarcondes commented Dec 20, 2021

ogupte commented Nov 19, 2021 •

edited

Loading