Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Omit elasticsearch field for policy update API (partial backport of #119131) #121412

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Dec 16, 2021

Summary

Backport of the fleet fix from #119131.

Contributes to fixing #121238 (comment)

Although the elasticsearch field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first.

Test steps

  • Add version 7.16.0 of the APM package to an agent policy
  • From the agent policy, select "Edit integration"
  • Edit the integration and save the edit
  • (there should be no error)

Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first.
Originally fixed in elastic#119131.

Co-authored-by: ogupte <[email protected]>
@hop-dev hop-dev added release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.16.2 labels Dec 16, 2021
@hop-dev hop-dev self-assigned this Dec 16, 2021
@hop-dev hop-dev marked this pull request as ready for review December 16, 2021 14:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 626.2KB 626.2KB +24.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 198d0e7 into elastic:7.16 Dec 16, 2021
@hop-dev hop-dev deleted the backport-fleet-fix-from-119131 branch December 16, 2021 15:45
ogupte added a commit to ogupte/kibana that referenced this pull request Jan 19, 2022
Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first.
Originally fixed in elastic#119131.

Co-authored-by: ogupte <[email protected]>

Co-authored-by: ogupte <[email protected]>
ogupte added a commit that referenced this pull request Jan 19, 2022
Although this field is returned in the GET response, we do not allow it to be set through the policy update API, so it must be omitted first.
Originally fixed in #119131.

Co-authored-by: ogupte <[email protected]>

Co-authored-by: ogupte <[email protected]>

Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.16.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants