-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] Updates Alerts table cell actions #116446
[RAC] Updates Alerts table cell actions #116446
Conversation
Looks like the test ObservabilityApp Observability alerts Alerts table Cell actions "before each" hook for "Copy button works" is failing after the removal of the Copy buttton. I'll address it tomorrow. The other test failure Uptime app with generated data When on the Synthetics Integration Policy Create Page create new policy allows saving when user enters a valid integration name and url/host doesn't seem related to this PR, maybe a flaky test? A rebase will hopefully address this. |
c0a459d
to
44462c6
Compare
@claudiopro Good job! I'll put some comments directly in the line numbers. Regarding failing tests yep uptime tests look irrelevant, so to update your PR just type @elasticmachine merge upstream in a comment (not sure if me typing this will re-run the PR, but in general you write above command and your PR re-runs or gets updated with latest master) Regarding copy button failing tests, here's how you run them locally. You first run the sever
And then you run the tests:
(you can grep accordingly) In order to link a PR with a Github issue you need to write |
@claudiopro according to ACs duration should have only the expand icon. We should remove the filter in/out options for the duration column. I want to comment regarding the issue you described when user filters in and then filters out the same value. I recommend we completely remove the Filter out functionality and properly implement it as part of this issue #116135, because now it looks broken and confusing. cc @katrin-freihofner @hbharding |
x-pack/plugins/observability/public/pages/alerts/filter_for_value.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/pages/alerts/filter_for_value.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/pages/alerts/filter_for_value.tsx
Outdated
Show resolved
Hide resolved
@claudiopro Here's an example of how you should label your PR #115171 once you open it for review |
af0ddde
to
d9ab1d2
Compare
d9ab1d2
to
7cbc1c2
Compare
@mgiota postponing the implementation of the Filter out action until we implement the filter manager seems reasonable to me. After acquiring more context, I agree we should avoid shipping a brittle implementation. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* Adds Filter Out button to alert table cell flyout * Adds translations * Fixes capitalization of labels * Removes unused declarations and imports * Fixes and adds functional tests for Alerts table action buttons * Addresses review comments * Fixes Alert table cell actions functional tests * Removes Filter out action for now Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Adds Filter Out button to alert table cell flyout * Adds translations * Fixes capitalization of labels * Removes unused declarations and imports * Fixes and adds functional tests for Alerts table action buttons * Addresses review comments * Fixes Alert table cell actions functional tests * Removes Filter out action for now Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Claudio Procida <[email protected]>
Summary
This PR fixes #111090 by
Adding a new Filter out action that excludes the given value from the queryI'm also tweaking the label text to use sentence-style capitalization as recommended by EUI writing guidelines.
Known issues
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers