Addresses review comments

elastic · Oct 28, 2021 · b127d51 · b127d51
1 parent 44462c6
commit b127d51
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/x-pack/plugins/timelines/public/components/t_grid/body/index.tsx b/x-pack/plugins/timelines/public/components/t_grid/body/index.tsx
@@ -151,6 +151,7 @@ const FIELDS_WITHOUT_CELL_ACTIONS = [
   '@timestamp',
   'signal.rule.risk_score',
   'signal.reason',
+  'kibana.alert.duration.us',
   'kibana.alert.reason',
 ];
 const hasCellActions = (columnId?: string) =>

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -7156,8 +7156,6 @@
     "xpack.observability.formatters.secondsTimeUnitLabel": "s",
     "xpack.observability.formatters.secondsTimeUnitLabelExtended": "秒",
     "xpack.observability.home.addData": "データの追加",
-    "xpack.observability.hoverActions.filterInValueButtonLabel": "Filter in",
-    "xpack.observability.hoverActions.filterOutValueButtonLabel": "Filter out",
     "xpack.observability.navigation.newBadge": "新規",
     "xpack.observability.news.readFullStory": "詳細なストーリーを読む",
     "xpack.observability.news.title": "新機能",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -7214,8 +7214,6 @@
     "xpack.observability.formatters.secondsTimeUnitLabel": "s",
     "xpack.observability.formatters.secondsTimeUnitLabelExtended": "秒",
     "xpack.observability.home.addData": "添加数据",
-    "xpack.observability.hoverActions.filterInValueButtonLabel": "Filter in",
-    "xpack.observability.hoverActions.filterOutValueButtonLabel": "Filter out",
     "xpack.observability.navigation.newBadge": "新建",
     "xpack.observability.news.readFullStory": "详细了解",
     "xpack.observability.news.title": "最新动态",

diff --git a/x-pack/test/observability_functional/apps/observability/alerts/index.ts b/x-pack/test/observability_functional/apps/observability/alerts/index.ts
@@ -188,13 +188,15 @@ export default ({ getService }: FtrProviderContext) => {
             const alertStatusCell = cells[2];
             await alertStatusCell.moveMouseTo();
             await retry.waitFor('cell actions visible', async () => {
+              let buttonsExist = false;
               try {
-                await observability.alerts.common.filterForValueButtonExists();
-                await observability.alerts.common.filterOutValueButtonExists();
+                buttonsExist = await observability.alerts.common.filterForValueButtonExists();
+                buttonsExist =
+                  buttonsExist && (await observability.alerts.common.filterOutValueButtonExists());
               } catch (_e) {
                 return false;
               }
-              return true;
+              return buttonsExist;
             });
           });
         });