-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] Observability alerts table: update cell actions #111090
Comments
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Updated description to clarify AC |
Hi @katrin-freihofner, what is the expected behavior when the user filters in and then filters out the same value? Should this result in the removal of the filter, as I'd assume? The alternative would result into adding two mutually exclusive conditions to the query (e.g. There is also another issue affecting current builds. The user can repeatedly filter in for the same value, resulting in a redundant KQL query which may also cause degradation of performance (I assume the KQL optimizer removes duplicate conditions?). |
@claudiopro good catches. We accepted these quirks in the interest of time back then with the intention to have the actions be backed by the structured filters and filter manager in the future. I created #116135 to track that effort. |
Thanks for the background @weltenwort! This is really helpful to understand some tradeoffs and design decisions made in code 😮 |
Hi @claudiopro! Thanks for asking. Yes, when users filter in and then filter out, this should cause the filter to be removed. The filters shouldn't build on top of eachother, as you described as an alternative. |
We want to update the cell actions in the Observability alerts table to improve usability. We defined the cell actions for our default columns and default actions for all optional columns.
AC:
Notes:
The text was updated successfully, but these errors were encountered: