Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Observability alerts table: update cell actions #111090

Closed
katrin-freihofner opened this issue Sep 3, 2021 · 6 comments · Fixed by #116446
Closed

[RAC] Observability alerts table: update cell actions #111090

katrin-freihofner opened this issue Sep 3, 2021 · 6 comments · Fixed by #116446
Assignees
Labels
polish Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.0.0

Comments

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Sep 3, 2021

We want to update the cell actions in the Observability alerts table to improve usability. We defined the cell actions for our default columns and default actions for all optional columns.

AC:

  • Timestamp and Duration column: expand action (no filter in/out)
  • Reason column: expand action (We decided this works ok based on how data grid "email" column example works)
  • All other columns: expand, filter in/out
  • Remove all other cell actions

Notes:

  • The design issue provides more background information and example of the consistent experience across solutions.
  • Observability specific proposed implementation:
    image
@katrin-freihofner katrin-freihofner added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services polish Theme: rac label obsolete labels Sep 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes
Copy link
Member

Updated description to clarify AC

@claudiopro claudiopro self-assigned this Oct 19, 2021
@claudiopro
Copy link
Contributor

Hi @katrin-freihofner, what is the expected behavior when the user filters in and then filters out the same value? Should this result in the removal of the filter, as I'd assume? The alternative would result into adding two mutually exclusive conditions to the query (e.g. kibana.alert.status: 'active' and not kibana.alert.status: 'active'), resulting into an empty result set:

Screen Shot 2021-10-25 at 12 25 06

There is also another issue affecting current builds. The user can repeatedly filter in for the same value, resulting in a redundant KQL query which may also cause degradation of performance (I assume the KQL optimizer removes duplicate conditions?).

Screen Shot 2021-10-25 at 12 21 14

@weltenwort
Copy link
Member

weltenwort commented Oct 25, 2021

@claudiopro good catches. We accepted these quirks in the interest of time back then with the intention to have the actions be backed by the structured filters and filter manager in the future. I created #116135 to track that effort.

@claudiopro
Copy link
Contributor

Thanks for the background @weltenwort! This is really helpful to understand some tradeoffs and design decisions made in code 😮

@hbharding
Copy link
Contributor

Hi @claudiopro! Thanks for asking. Yes, when users filter in and then filter out, this should cause the filter to be removed. The filters shouldn't build on top of eachother, as you described as an alternative.

@jasonrhodes jasonrhodes added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants