[saved objects] Remove migrations enableV2 config.

[lukeelmers]

[skip-ci]

Part of #96396

This marks the enableV2 migrations config (deprecated in 7.12) as unused. As a result, users won't be able to use v1 migrations from 7.16.

Due to the way the SO config types were handled, it requires removing a few pieces of code, however it doesn't remove the full set of v1 migration code as outlined in #96396.

[lukeelmers]

I tried to minimize the code that was removed here, but due to the way soMigrationsConfig is typed, I had to take this out.

[lukeelmers]

The one failure here is a unit test from the kibana_migrator suite: https://buildkite.com/elastic/kibana-pull-request/builds/521#87ef5d5b-7bf8-450a-a53a-72499774a19a

I think it just needs to be mocked differently for v2, but hadn't gotten to look more closely at it yet.

  | FAIL  src/core/server/saved_objects/migrations/kibana/kibana_migrator.test.ts
  | ● KibanaMigrator › runMigrations › only runs migrations once if called multiple times
  |  
  | expect(jest.fn()).toHaveBeenCalledTimes(expected)
  |  
  | Expected number of calls: 1
  | Received number of calls: 0
  |  
  | 146 \|       await migrator.runMigrations();
  | 147 \|
  | > 148 \|       expect(options.client.cat.templates).toHaveBeenCalledTimes(1);
  | \|                                            ^
  | 149 \|     });
  | 150 \|
  | 151 \|     it('emits results on getMigratorResult$()', async () => {
  |  
  | at Object.<anonymous> (src/core/server/saved_objects/migrations/kibana/kibana_migrator.test.ts:148:44)
  |  
  |  
  | Test Suites: 1 failed, 31 skipped, 6397 passed, 6398 of 6429 total
  | Tests:       1 failed, 218 skipped, 12 todo, 48231 passed, 48462 total
  | Snapshots:   7125 passed, 7125 total

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[jbudz]

kibana-docker LGTM

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[jbudz]

I just wanted to double check, is the plan to partially backport this to 7.16? Or are we removing the config altogether?

[lukeelmers]

I just wanted to double check, is the plan to partially backport this to 7.16? Or are we removing the config altogether?

Core team is still discussing this. We had originally planned to just merge this for 8.0, but as we have explicitly documented that the config could be removed in a minor and it only existed for debugging purposes, we had a last minute discussion today about possibly backporting to 7.16 as well (to simplify long term support).

The config removal ended up being a bit more widespread than initially anticipated, so the rest of the team is going to decide tomorrow morning in EMEA whether we want to try to push this through before the first 7.16 BC is kicked off. If we can't make that happen, we'll stick with 8.0 only.

[shahzad31]

Uptime changes LGTM !!

[kibanamachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: bb8e14d
• Storybooks Preview

Test Failures

• [job] [logs] Jest Tests / Dashboard container lifecycle Old dashboard container is destroyed when new dashboardId is given

Metrics [docs]

✅ unchanged

History

• 💔 Build #521 failed 86526d4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukeelmers

[cauemarcondes]

APM changes LGTM

[lukeelmers]

Chatted with @brianseeders -- the buildkite build is passing, but did not update the kibana-ci check on this PR after the test was retried. Ops team will investigate a fix for this, but in the meantime we should be safe to merge.

[kibanamachine]

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 115655