Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove v1 migrations #96396

Closed
rudolf opened this issue Apr 7, 2021 · 6 comments · Fixed by #118000
Closed

[Core] Remove v1 migrations #96396

rudolf opened this issue Apr 7, 2021 · 6 comments · Fixed by #118000
Assignees
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@rudolf
Copy link
Contributor

rudolf commented Apr 7, 2021

We kept v1 migrations as a backup to workaround any issues we might see with v2 migrations. But since we're not actively testing v1 migrations on releases anymore we should aim to remove it as soon as possible to avoid regressions (such as #95617)

Since the only known problem has been solved in 7.12.1 we could keep it for 7.13 as an extra buffer, but then remove it in 7.14.0.

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient labels Apr 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf
Copy link
Contributor Author

rudolf commented Apr 7, 2021

Although the config value migrations.enableV2 will be deprecated in 7.12.1 (#96398) some users might not remember to remove this. It might be better to keep this configuration option but just ignore it's value than to fail to startup so that users who previously opted in to stay with V1 migrations will automatically start using v2 migrations?

@pgayvallet
Copy link
Contributor

pgayvallet commented Apr 8, 2021

Is #91618 a blocker for that one?

@afharo
Copy link
Member

afharo commented Apr 8, 2021

We are now using V2 everywhere. There should be no blockers.

@joshdover
Copy link
Contributor

Although the config value migrations.enableV2 will be deprecated in 7.12.1 (#96398) some users might not remember to remove this. It might be better to keep this configuration option but just ignore it's value than to fail to startup so that users who previously opted in to stay with V1 migrations will automatically start using v2 migrations?

+1 on this. This mirrors how we handle any of the xpack.code.* configs when that application was removed.

@pgayvallet
Copy link
Contributor

We could just use an unused config deprecation, which would have the advantage to warn the user that this option is no longer required.

@pgayvallet pgayvallet self-assigned this Apr 30, 2021
@lukeelmers lukeelmers added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort technical debt Improvement of the software architecture and operational architecture labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
6 participants