Deprecate migrations.enableV2 #96398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
release_note:deprecation
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Apr 7, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
mshustov
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2021
* deprecate migrations.enableV2 * provide deprecation test tool from core * use deprecation test tool in tests * add a test for SO depreacations
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2021
* deprecate migrations.enableV2 * provide deprecation test tool from core * use deprecation test tool in tests * add a test for SO depreacations Co-authored-by: Mikhail Shustov <[email protected]>
|
@mshustov how do I test this please? add the parameter in kibana.yml and see if deprecated logs show up? Thanks! |
|
@bhavyarm yes, you should be able to see a warning message in logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Core team is going to remove the
migrations.enableV2setting as soon as migrations v2 are stable. Technically, speaking it's an implementation detail, which is not subject to the compatibility guarantees.In this PR, I had to create a helper to test deprecations. It might be better to review code commit by commit.
Checklist
Delete any items that are not applicable to this PR.