Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.16] [saved objects] Remove migrations enableV2 config. (#115655) #115800

Closed
wants to merge 3 commits into from
Closed

[7.16] [saved objects] Remove migrations enableV2 config. (#115655) #115800

wants to merge 3 commits into from

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Oct 20, 2021 •
edited
Loading

[skip ci]

Backports the following commits to 7.16:

@lukeelmers
[saved objects] Remove migrations enableV2 config. (elastic#115655)
f6087c6 
# Conflicts:
#	src/core/server/saved_objects/migrationsv2/integration_tests/migration_from_older_v1.test.ts
#	src/core/server/saved_objects/migrationsv2/integration_tests/migration_from_same_v1.test.ts
@lukeelmers lukeelmers enabled auto-merge (squash) October 20, 2021 15:27
@tylersmalley tylersmalley deleted the branch elastic:7.16 October 20, 2021 16:09
auto-merge was automatically disabled October 20, 2021 16:09

Pull request was closed

@lukeelmers lukeelmers reopened this Oct 20, 2021
@lukeelmers lukeelmers changed the title [7.x] [saved objects] Remove migrations enableV2 config. (#115655) [7.16] [saved objects] Remove migrations enableV2 config. (#115655) Oct 20, 2021
@lukeelmers lukeelmers enabled auto-merge (squash) October 20, 2021 16:13
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@tylersmalley tylersmalley deleted the branch elastic:7.16 October 20, 2021 16:14
auto-merge was automatically disabled October 20, 2021 16:14

Pull request was closed

@tylersmalley tylersmalley reopened this Oct 20, 2021
@lukeelmers lukeelmers enabled auto-merge (squash) October 20, 2021 16:18
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine

This comment has been minimized.

Sign in to view
@lukeelmers lukeelmers closed this Oct 20, 2021
auto-merge was automatically disabled October 20, 2021 17:50

Pull request was closed

@lukeelmers lukeelmers deleted the backport/7.x/pr-115655 branch October 20, 2021 17:51
@lukeelmers
Copy link
Member Author

This backport got into a weird state as the 7.x -> 7.16 branch change happened right after it was opened. Closing in favor of #115839

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests / migrating from the same Kibana version that used v1 migrations copies the documents from the previous index to the new one
  • [job] [logs] Jest Integration Tests / migrating from the same Kibana version that used v1 migrations creates the new index and the correct aliases
  • [job] [logs] Jest Integration Tests / migrating from the same Kibana version that used v1 migrations migrates the documents to the highest version

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport buildkite-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukeelmers @kibanamachine @tylersmalley