CSS fix for scrollable doc table in FireFox #10592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
Feb 27, 2017
| .doc-table-container { | ||
| flex: 1 1 0; | ||
| overflow: auto; | ||
| } |
There was a problem hiding this comment.
Would you mind adding these comments?
/**
* 1. Stack content vertically so the table can scroll when its constrained by a fixed container height.
*/
doc-table {
overflow: auto;
flex: 1 1 100%;
flex-direction: column; /* 1 */
/**
* 1. Allow user to scroll table when its constrained by a fixed container height.
*/
.doc-table-container {
flex: 1 1 0; /* 1 */
overflow: auto; /* 1 */
}
elastic-jasper
added a commit
that referenced
this pull request
Feb 27, 2017
Backports PR #10592 **Commit 1:** CSS fix for scrollable doc table in FireFox * Original sha: 9551029 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T16:01:23Z **Commit 2:** add comments * Original sha: e162049 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T18:40:20Z
stacey-gammon
pushed a commit
that referenced
this pull request
Feb 27, 2017
Backports PR #10592 **Commit 1:** CSS fix for scrollable doc table in FireFox * Original sha: 9551029 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T16:01:23Z **Commit 2:** add comments * Original sha: e162049 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T18:40:20Z
|
@stacey-gammon Can you backport this to 5.3 as well so it can go out in 5.3.1? |
elastic-jasper
added a commit
that referenced
this pull request
Feb 28, 2017
Backports PR #10592 **Commit 1:** CSS fix for scrollable doc table in FireFox * Original sha: 9551029 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T16:01:23Z **Commit 2:** add comments * Original sha: e162049 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T18:40:20Z
stacey-gammon
pushed a commit
that referenced
this pull request
Feb 28, 2017
Backports PR #10592 **Commit 1:** CSS fix for scrollable doc table in FireFox * Original sha: 9551029 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T16:01:23Z **Commit 2:** add comments * Original sha: e162049 * Authored by Stacey Gammon <[email protected]> on 2017-02-27T18:40:20Z
|
Thank you! |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 15, 2017
Some CSS changes were made in elastic#10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes elastic#12416
Bargs
added a commit
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in #10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes #12416
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in elastic#10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes elastic#12416
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in elastic#10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes elastic#12416
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in elastic#10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes elastic#12416
This was referenced Aug 17, 2017
Bargs
added a commit
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in #10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes #12416
Bargs
added a commit
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in #10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes #12416
Bargs
added a commit
that referenced
this pull request
Aug 17, 2017
Some CSS changes were made in #10592 which caused the fixed-scroll directive to stop working in Discover. Specifically the overflow rule which was added forced the width and scrollWidth of the doc-container to be the same, so the fixed-scroll directive would never add the scroll bar to the page. This PR simply reverts the changes made in the above linked PR. I retested the original issues in the latest version of Firefox and was unable to reproduce. It seems that the original issues may have been fixed in Firefox itself. Fixes #12416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc tables were not scrollable in ff, this should fix the issue. I followed the css that visualize was using to make data tables scrollable.
Fixes #10305 and #10303.