Skip to content

Commit

Permalink
Fix fixed-scroll on Discover page (#13516) (#13557)
Browse files Browse the repository at this point in the history
Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416
  • Loading branch information
Bargs authored Aug 17, 2017
1 parent 97c4dfb commit a52c45c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 8 additions & 0 deletions src/core_plugins/kibana/public/dashboard/styles/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,12 @@ dashboard-panel {
height: auto;
}
}

/**
* 1. We want the doc-table-container to scroll only when embedded in a dashboard panel
*/
.doc-table-container {
flex: 1 1 0; /* 1 */
overflow: auto; /* 1 */
}
}
8 changes: 0 additions & 8 deletions src/ui/public/doc_table/doc_table.less
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ doc-table {
flex: 1 1 100%;
flex-direction: column; /* 1 */

/**
* 1. Allow user to scroll table when its constrained by a fixed container height.
*/
.doc-table-container {
flex: 1 1 0; /* 1 */
overflow: auto; /* 1 */
}

.discover-table-datafield {
white-space: pre-wrap;

Expand Down

0 comments on commit a52c45c

Please sign in to comment.